New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement LINE Messaging API #14867
Merged
Merged
Implement LINE Messaging API #14867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j796160836
force-pushed
the
apply_cleanup
branch
2 times, most recently
from
April 11, 2023 15:03
5cc78f5
to
57c0230
Compare
Thanks @j796160836 for updating. #14763 depends on Laravel 9 to be merged, so working on that. |
j796160836
force-pushed
the
apply_cleanup
branch
from
July 11, 2023 01:27
5034e9f
to
d98d6d1
Compare
murrant
changed the title
Apply code cleanup (Implement LINE Messaging API)
Implement LINE Messaging API
Aug 4, 2023
murrant
approved these changes
Aug 4, 2023
TheMysteriousX
pushed a commit
to TheMysteriousX/librenms
that referenced
this pull request
Aug 9, 2023
* implement LINE Messaging api * apply code clean up * Update Linemessagingapi.php * fix variable type * Match branding * Remove extra proxy --------- Co-authored-by: Neil Lathwood <gh+n@laf.io> Co-authored-by: Tony Murray <murraytony@gmail.com>
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
Thanks murrant, thanks again. 🙇♂️ |
peejaychilds
pushed a commit
to peejaychilds/librenms
that referenced
this pull request
Oct 26, 2023
* implement LINE Messaging api * apply code clean up * Update Linemessagingapi.php * fix variable type * Match branding * Remove extra proxy --------- Co-authored-by: Neil Lathwood <gh+n@laf.io> Co-authored-by: Tony Murray <murraytony@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous commit #14802 implement LINE Messaging API.
According to #14763 code clean up, apply with this modification.
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.