Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LINE Messaging API #14867

Merged
merged 6 commits into from Aug 4, 2023
Merged

Conversation

j796160836
Copy link
Contributor

Previous commit #14802 implement LINE Messaging API.
According to #14763 code clean up, apply with this modification.


Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2023

CLA assistant check
All committers have signed the CLA.

@j796160836 j796160836 force-pushed the apply_cleanup branch 2 times, most recently from 5cc78f5 to 57c0230 Compare April 11, 2023 15:03
@murrant
Copy link
Member

murrant commented Apr 14, 2023

Thanks @j796160836 for updating. #14763 depends on Laravel 9 to be merged, so working on that.

@murrant murrant changed the title Apply code cleanup (Implement LINE Messaging API) Implement LINE Messaging API Aug 4, 2023
@murrant murrant mentioned this pull request Aug 4, 2023
3 tasks
@murrant murrant added this to the 23.8.0 milestone Aug 4, 2023
@murrant murrant merged commit de65ff5 into librenms:master Aug 4, 2023
9 checks passed
TheMysteriousX pushed a commit to TheMysteriousX/librenms that referenced this pull request Aug 9, 2023
* implement LINE Messaging api

* apply code clean up

* Update Linemessagingapi.php

* fix variable type

* Match branding

* Remove extra proxy

---------

Co-authored-by: Neil Lathwood <gh+n@laf.io>
Co-authored-by: Tony Murray <murraytony@gmail.com>
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-8-0-changelog/22078/1

@j796160836
Copy link
Contributor Author

Thanks murrant, thanks again. 🙇‍♂️

peejaychilds pushed a commit to peejaychilds/librenms that referenced this pull request Oct 26, 2023
* implement LINE Messaging api

* apply code clean up

* Update Linemessagingapi.php

* fix variable type

* Match branding

* Remove extra proxy

---------

Co-authored-by: Neil Lathwood <gh+n@laf.io>
Co-authored-by: Tony Murray <murraytony@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants