Update hikvision camera detection #14943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hikvision cameras model number does not forcibly starts with 'DS-' anymore. Here is an sample of a OEM new model made by HIKVISION [ .1.3.6.1.4.1.39165.1.1.0 = STRING: "IPC7A27-ANPR" .1.3.6.1.4.1.39165.1.2.0 = STRING: "0" .1.3.6.1.4.1.39165.1.3.0 = STRING: "V5.7.80 build 220525" .1.3.6.1.4.1.39165.1.4.0 = STRING: "98-f1-12-c7-0b-a2" .1.3.6.1.4.1.39165.1.5.0 = STRING: "88" .1.3.6.1.4.1.39165.1.6.0 = STRING: "IPcamera" .1.3.6.1.4.1.39165.1.7.0 = STRING: "38 PERCENT" ...]
|
|
electrocret
approved these changes
Apr 6, 2023
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
TheMysteriousX
pushed a commit
to TheMysteriousX/librenms
that referenced
this pull request
Aug 9, 2023
Hikvision cameras model number does not forcibly starts with 'DS-' anymore. Here is an sample of a OEM new model made by HIKVISION [ .1.3.6.1.4.1.39165.1.1.0 = STRING: "IPC7A27-ANPR" .1.3.6.1.4.1.39165.1.2.0 = STRING: "0" .1.3.6.1.4.1.39165.1.3.0 = STRING: "V5.7.80 build 220525" .1.3.6.1.4.1.39165.1.4.0 = STRING: "98-f1-12-c7-0b-a2" .1.3.6.1.4.1.39165.1.5.0 = STRING: "88" .1.3.6.1.4.1.39165.1.6.0 = STRING: "IPcamera" .1.3.6.1.4.1.39165.1.7.0 = STRING: "38 PERCENT" ...]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hikvision cameras model number does not forcibly starts with 'DS-' anymore.
Here is an sample of a new OEM model made by HIKVISION
[
.1.3.6.1.4.1.39165.1.1.0 = STRING: "IPC7A27-ANPR"
.1.3.6.1.4.1.39165.1.2.0 = STRING: "0"
.1.3.6.1.4.1.39165.1.3.0 = STRING: "V5.7.80 build 220525"
...
.1.3.6.1.4.1.39165.1.6.0 = STRING: "IPcamera"
...]
Please give a short description what your pull request is for
Instead of searching for a string starting with 'DS-', this allow to add models with just the sysObjectID of HIKVISION
It's a very small change and its impact only devices having sysObjectID of HIKVISION cameras
Sorry I'm not able to do test right now because of lack of time but hope this minor change will be accepted and helps.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.