Add support for Trellix NSP devices #14964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you remove unused mibs? We try to only keep the ones actually used |
- Add discovery for mlos NSP devices - Monitor port statistics from non standard MIBs - Add Trellix MIBs - Add test data
mtentilucci
force-pushed
the
add-mlos-nsp-support
branch
from
88852c6
to
f2a0fd1
Compare
|
@Jellyfrog PR ready for your review. |
Jellyfrog
approved these changes
Apr 30, 2023
|
Hi @Jellyfrog, are there any other changes needed to merge this branch? |
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
TheMysteriousX
pushed a commit
to TheMysteriousX/librenms
that referenced
this pull request
Aug 9, 2023
* Add support for Trellix NSP devices - Add discovery for mlos NSP devices - Monitor port statistics from non standard MIBs - Add Trellix MIBs - Add test data * Fix StyleCI findings * Rename MIB files to match MIB names, remove unused MIBs * regenerate mlos-nsp_ns9500.json to account for changes from PR#14963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Trellix NSP. The devices run mlos (McAfee Linux OS), McAfee and FireEye recently merged and formed a new company - Trellix. The Trellix NSPs use the Trellix MIBs which are just renamed and updated McAfee MIBs.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.