Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set device ping_perf scale_min to 0 #14989

Merged
merged 1 commit into from Apr 21, 2023
Merged

Conversation

murrant
Copy link
Member

@murrant murrant commented Apr 20, 2023

And allow scale_min, scale_max, and scale_rigid to be set via url parameter

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

And allow scale_min, scale_max, and scale_rigid to be set via url parameter
@murrant murrant added the Graphs label Apr 20, 2023
@electrocret electrocret merged commit 2ddfba5 into librenms:master Apr 21, 2023
9 checks passed
@murrant murrant deleted the graph_scale branch April 21, 2023 16:55
@fcqpl
Copy link
Contributor

fcqpl commented Apr 21, 2023

Hi @murrant,
This commit added some unwanted padding at top of chart. Can you look at this?
Before:
chrome_BaLSOk3CXV
After:
chrome_JaDg92srfv

@murrant
Copy link
Member Author

murrant commented Apr 22, 2023

Odd, maybe rigid is set now

@murrant
Copy link
Member Author

murrant commented Apr 22, 2023

@fcqpl try this #14992 Please respond there if it fixes your issue.

@fcqpl
Copy link
Contributor

fcqpl commented Apr 22, 2023

@murrant, #14992 fixes this issue. Thanks!

ajsiersema pushed a commit to ajsiersema/librenms that referenced this pull request Apr 24, 2023
And allow scale_min, scale_max, and scale_rigid to be set via url parameter
laf pushed a commit to ptx-tech/librenms that referenced this pull request Apr 27, 2023
And allow scale_min, scale_max, and scale_rigid to be set via url parameter
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-5-0-changelog/21481/1

TheMysteriousX pushed a commit to TheMysteriousX/librenms that referenced this pull request Aug 9, 2023
And allow scale_min, scale_max, and scale_rigid to be set via url parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants