Apply service templates on a per-device basis #15024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrocret
approved these changes
Aug 5, 2023
TheMysteriousX
pushed a commit
to TheMysteriousX/librenms
that referenced
this pull request
Aug 9, 2023
* Created and use a function to apply service templates on a per-device basis * formatting fix
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
peejaychilds
pushed a commit
to peejaychilds/librenms
that referenced
this pull request
Oct 26, 2023
* Created and use a function to apply service templates on a per-device basis * formatting fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently started using service templates, and I noticed that during discovery there are a lot of log messages saying services are being deleted from devices. I traced the issue to the use of the applyAll() function, which was causing the service template to evaluate the template apply rules for every device every time each device is discovered. This adds about 5s to the discovery time per device.
The proposed pull request replaces the applyAll() function call with an applyDeviceAll() function call, which only evaluates the service template rules for the device being discovered.