add sensor support for cefcModuleOperStatus #15026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jellyfrog
reviewed
May 8, 2023
|
Could this be implemented in yaml instead? We try to only use php if it needs more advanced parsing |
….com/d-k-7/librenms into add-sensors-for-cefcModuleOperStatus
@Jellyfrog I implemented this in yaml rather than php. I also added the sensors to a group to help improve readability.
|
Jellyfrog
approved these changes
May 24, 2023
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
TheMysteriousX
pushed a commit
to TheMysteriousX/librenms
that referenced
this pull request
Aug 9, 2023
* add sensor support for cefcModuleOperStatus * add tests for cefcModuleOperStatus * revert sensors/state/cisco.inc.php * add sensor support for cefcModuleOperStatus using yaml * update tests for cefcModuleOperStatus * try adding tests again for cefcModuleOperStatus * include CISCO-ENTITY-FRU-CONTROL mib for cefcModuleOperStatus sensor state discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds state sensor support for linecard operating status for Cisco switches using the cefcModuleOperStatus OID
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.