Sort port by interface name while list ports. #15093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Jellyfrog
reviewed
Jun 11, 2023
html/ajax_listports.php
Outdated
| $interface = cleanPort($interface); | ||
| $interface_map[$interface['label']] = $interface; | ||
| } | ||
| $interface_names = array_keys($interface_map); |
There was a problem hiding this comment.
Is there any point in doing array_keys and sort instead of just ksort?
There was a problem hiding this comment.
You are right, changed
Jellyfrog
approved these changes
Jun 24, 2023
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
TheMysteriousX
pushed a commit
to TheMysteriousX/librenms
that referenced
this pull request
Aug 9, 2023
* Sort port by interface name while list ports. * Remove sql sort * use ksort instead of sort manually * Update ajax_listports.php --------- Co-authored-by: Tony Murray <murraytony@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort port by interface name while list ports, which is beneficiary for who have many ports.
Screenshots
Before
After
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.