add generic stats graph munging support and make uptime display as days again #15097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murrant
requested changes
Jun 18, 2023
Awesome. Done! :) Any reason we don't want it selectable or just wanting to avoid CPU overhead for something that is not going to be commonly used? |
VVelox
changed the title
murrant
approved these changes
Aug 2, 2023
|
@VVelox added settings is the death of LibreNMS (maintainability). Basically, hidden options end up with unused code paths which is very bad for maintainability. Whenever, I could add an option I think: Is this necessary? Was this asked for? Could a good default just be better? |
TheMysteriousX
pushed a commit
to TheMysteriousX/librenms
that referenced
this pull request
Aug 9, 2023
…ys again (librenms#15097) * add munging to generic stats graph include * add graph_uptime_days config def * make it optionally changable now * style fix * remove the graph_uptime_days option
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
peejaychilds
pushed a commit
to peejaychilds/librenms
that referenced
this pull request
Oct 26, 2023
…ys again (librenms#15097) * add munging to generic stats graph include * add graph_uptime_days config def * make it optionally changable now * style fix * remove the graph_uptime_days option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in munging to the generic stats graph.
Also revert uptime back to being days again and make it able to optionally show in graphs as either days or seconds via a new config def.
fixes #15091
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.