Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change state value for unplugged linecard #15126

Merged
merged 1 commit into from Jun 28, 2023
Merged

Change state value for unplugged linecard #15126

merged 1 commit into from Jun 28, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 28, 2023

Please give a short description what your pull request is for:

I updated the line-card state to change the state from "unknown" to "warning." This change aims to draw attention to potential issues when a line-card transitions from an active/working state to "Unplugged." This state should indicate an unexpected removal of the card or a failure in detecting it. However, if the slot is empty without a line-card inserted, it will be labeled as "Empty" without triggering a warning.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • [x ] Have you followed our code guidelines?
  • [ x] If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • [ x] If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@Jellyfrog Jellyfrog added the Device 🖥️ New or added device support label Jun 28, 2023
@Jellyfrog Jellyfrog merged commit 8081a3f into librenms:master Jun 28, 2023
9 checks passed
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-7-0-changelog/21841/1

TheMysteriousX pushed a commit to TheMysteriousX/librenms that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants