update SMART monitoring to the use JSON #15132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need to tweak the tests as I've not fully filled that all out, but it is done and I am happy with the status! :3 |
Jellyfrog
approved these changes
Jul 24, 2023
TheMysteriousX
pushed a commit
to TheMysteriousX/librenms
that referenced
this pull request
Aug 9, 2023
* rework into a json app and support the old style * working now * add health checking * add some datapoints to make writing alerts easy * add a few missing item for has checks * rework the app page * use the right var for id9 * print the self test log if we have it * add a graph for the max temp * display the max temp graph * display the health pass in the disk list if we have the data * fix legacy handling and set app as ok * replace id190 and id194 with the more useful maxtemp graph on the apps page * don't print the additional info area for legacy extends * add id232 * add id252 graph support * properly display id232 now * do not display SSD graphs for non-SSD disks * for legacy extends, make sure we don't have a bad line * add missing label for Product value * fix metrics * rework the metrics stuff a bit more * typo fix * more smart metrics cleanup * add exit info to metrics * style cleanup and logic checking for when disks are all now fine * fix checking for no more health errors * update the docs for SMART for v1 and remove slightly pointless notes about useSN * update the docs * initial test stuff * add missing tests for the legacy code * save if it it is legacy or not * style cleanup * update the smart legacy test * style cleanup * more test tweaking * some more style cleanup * more test fixes * correct the disk ID for the legacy test da0 -> Z304VCFY * more tests update * more test cleanup * begin cleanup of the v1 tests * more v1 test updates * more tests for v1 * more test cleanup * fix exit_nonzero and add unhealthy metric * add smart alerts * add the metric unhealthy to the stat test * use app data for the smart-common.inc.php
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
peejaychilds
pushed a commit
to peejaychilds/librenms
that referenced
this pull request
Oct 26, 2023
* rework into a json app and support the old style * working now * add health checking * add some datapoints to make writing alerts easy * add a few missing item for has checks * rework the app page * use the right var for id9 * print the self test log if we have it * add a graph for the max temp * display the max temp graph * display the health pass in the disk list if we have the data * fix legacy handling and set app as ok * replace id190 and id194 with the more useful maxtemp graph on the apps page * don't print the additional info area for legacy extends * add id232 * add id252 graph support * properly display id232 now * do not display SSD graphs for non-SSD disks * for legacy extends, make sure we don't have a bad line * add missing label for Product value * fix metrics * rework the metrics stuff a bit more * typo fix * more smart metrics cleanup * add exit info to metrics * style cleanup and logic checking for when disks are all now fine * fix checking for no more health errors * update the docs for SMART for v1 and remove slightly pointless notes about useSN * update the docs * initial test stuff * add missing tests for the legacy code * save if it it is legacy or not * style cleanup * update the smart legacy test * style cleanup * more test tweaking * some more style cleanup * more test fixes * correct the disk ID for the legacy test da0 -> Z304VCFY * more tests update * more test cleanup * begin cleanup of the v1 tests * more v1 test updates * more tests for v1 * more test cleanup * fix exit_nonzero and add unhealthy metric * add smart alerts * add the metric unhealthy to the stat test * use app data for the smart-common.inc.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds tests for the legacy code as well. This also will avoid showing graphs that are not relevant as well, only showing graphs if one or more devices have data that supports it.
Apparently that was missing.
Also now will show drive info such as serial, what tests have been run, and the like... https://i.imgur.com/6eb58m0.jpg
Also now shows device status(if failling or ok)... https://i.imgur.com/Bs70CZd.png
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.