Use full name for vendor_oui #15234
Merged
Use full name for vendor_oui #15234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reason I used the short name is due to column width in tables. Feel free to change it to store both short and long names and use in the appropriate spots. |
|
Ok. New PR in #15236 |
3 tasks
|
Trimmed variables to get rid of unnecessary blanks after split of the CSV. |
PipoCanaja
force-pushed
the
PipoCanaja-patch-2
branch
from
66816ee
to
c3ede34
Compare
|
Tested successfully, search working as well. Looks good from my pov. |
murrant
approved these changes
Aug 21, 2023
3 tasks
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
peejaychilds
pushed a commit
to peejaychilds/librenms
that referenced
this pull request
Oct 26, 2023
* Use full name for vendor_oui * trimmed * typo * more spaces to remove * don't set $short_vendor * keep line return --------- Co-authored-by: Tony Murray <murraytony@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When code was reworked to store in DB, short name (field 2 of CSV) was used. This is incomplete (truncated). This PR restores the full registered IEEE name which is in the 3rd column of the CSV.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.