Revert "Added empty string check" #15249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cbe2ba5.
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
|
Hello. This fix breaks the rules logic. The fact is that zero and null are neither the same thing. If nothing was specified in the parameter set, the value of null was written to the database. Now a zero is written there. This breaks the rules and imposes additional load on SQL queries. After editing and saving the parameters, null is overwritten with zero, which causes false positives of the rules. |
|
This has nothing to do with writing to the database. If you have an issue, please open a ticket with a detailed explanation of the problem. |
peejaychilds
pushed a commit
to peejaychilds/librenms
that referenced
this pull request
Oct 26, 2023
This reverts commit cbe2ba5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #15235
fixes: #15240