Add unzip to all install docs dependencies #15354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composer complains that neither unzip nor 7z is installed so it would unzip using PHP which may or may not corrupt the results file. This has always worked fine for me but I guess it might be a better idea to use the "real" unzipper. ``` librenms@librenms1:~$ ./scripts/composer_wrapper.php install --no-dev Could not scan for classes inside "vendor/dapphp/radius" which does not appear to be a file nor a folder > LibreNMS\ComposerHelper::preInstall Installing dependencies from lock file Verifying lock file contents can be installed on current platform. Package operations: 118 installs, 0 updates, 0 removals As there is no 'unzip' nor '7z' command installed zip files are being unpacked using the PHP zip extension. This may cause invalid reports of corrupted archives. Besides, any UNIX permissions (e.g. executable) defined in the archives will be lost. Installing 'unzip' or '7z' (21.01+) may remediate them. ```
|
|
|
I don't understand why this is needed. Did something fail? |
|
@murrant It avoids the error/warning about unzip/7zip not being present. :) |
|
Hello! I agree this is not a big update. But yes, with unzip installed you can avoid the warning from composer that it needs to decompress archives on its own rather than use a dedicated binary. |
|
If this is truly the case, shouldn't all install docs be updated? Or is Debian the only one that doesn't have unzip? Please keep the packages alphabetical. |
Sorted 'unzip' package alphabetically in Debian, Ubuntu and CentOS installation steps.
brointhemix
commented
Sep 27, 2023
|
When I checked right now all other steps had unzip added except Ubuntu Apache section. |
murrant
changed the title
murrant
approved these changes
Sep 27, 2023
|
Thanks for reviewing and accepting @murrant :) |
peejaychilds
pushed a commit
to peejaychilds/librenms
that referenced
this pull request
Oct 26, 2023
* Update Install-LibreNMS.md Composer complains that neither unzip nor 7z is installed so it would unzip using PHP which may or may not corrupt the results file. This has always worked fine for me but I guess it might be a better idea to use the "real" unzipper. ``` librenms@librenms1:~$ ./scripts/composer_wrapper.php install --no-dev Could not scan for classes inside "vendor/dapphp/radius" which does not appear to be a file nor a folder > LibreNMS\ComposerHelper::preInstall Installing dependencies from lock file Verifying lock file contents can be installed on current platform. Package operations: 118 installs, 0 updates, 0 removals As there is no 'unzip' nor '7z' command installed zip files are being unpacked using the PHP zip extension. This may cause invalid reports of corrupted archives. Besides, any UNIX permissions (e.g. executable) defined in the archives will be lost. Installing 'unzip' or '7z' (21.01+) may remediate them. ``` * Update Install-LibreNMS.md Sorted 'unzip' package alphabetically in Debian, Ubuntu and CentOS installation steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Debian 11 installation, Composer complains that neither unzip nor 7z is installed so it would unzip using PHP which may or may not corrupt the results file. This has always worked fine for me but I guess it might be a better idea to use the "real" unzipper.
I added 'unzip' to the list of installed software for Debian 11 steps in the documentation. I made no other changes.
Please give a short description what your pull request is for
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.