Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutable acknowledged alert notifications #15456

Merged
merged 1 commit into from Oct 14, 2023

Conversation

SourceDoctor
Copy link
Member

Ability to disable Alert Transport Notification about Alert Acknowledgement

image

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@SourceDoctor SourceDoctor changed the title muteabel acknowledged alert notifications muteable acknowledged alert notifications Oct 13, 2023
Copy link
Member

@electrocret electrocret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@electrocret electrocret merged commit 0f0f496 into librenms:master Oct 14, 2023
10 checks passed
peejaychilds pushed a commit to peejaychilds/librenms that referenced this pull request Oct 26, 2023
@murrant murrant changed the title muteable acknowledged alert notifications Mutable acknowledged alert notifications Oct 27, 2023
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-10-0-release-announcement/22646/1

gdepeyrot pushed a commit to gdepeyrot/librenms that referenced this pull request Nov 29, 2023
gdepeyrot pushed a commit to gdepeyrot/librenms that referenced this pull request Nov 29, 2023
gunkaaa pushed a commit to gunkaaa/librenms that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants