ports ifPhysAddress use MAC helper #15478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent divide by 0 Use Mac utility
either the script is capturing them wrong or users are mangling them
murrant
force-pushed
the
ifphysaddress-use-helper
branch
from
f87fbc1
to
9e4bfac
Compare
Jellyfrog
approved these changes
Oct 19, 2023
peejaychilds
pushed a commit
to peejaychilds/librenms
that referenced
this pull request
Oct 26, 2023
* Ports min polled period of 1 Prevent divide by 0 Use Mac utility * fix bad snmprec for airos-af-ltu * Update a large amount of invalid mac addresses either the script is capturing them wrong or users are mangling them * More updated test data * Update test data with bad input * Fix ones using encoded <private> and attempt to fix capture * Update awplus data * restore missing data * update other DNOS * Fix ones using encoded <private> and attempt to fix capture * Fix ones using encoded <private> and attempt to fix capture * fix typo * Update some data * update data * update ruijie
gdepeyrot
pushed a commit
to gdepeyrot/librenms
that referenced
this pull request
Nov 29, 2023
* Ports min polled period of 1 Prevent divide by 0 Use Mac utility * fix bad snmprec for airos-af-ltu * Update a large amount of invalid mac addresses either the script is capturing them wrong or users are mangling them * More updated test data * Update test data with bad input * Fix ones using encoded <private> and attempt to fix capture * Update awplus data * restore missing data * update other DNOS * Fix ones using encoded <private> and attempt to fix capture * Fix ones using encoded <private> and attempt to fix capture * fix typo * Update some data * update data * update ruijie
gunkaaa
pushed a commit
to gunkaaa/librenms
that referenced
this pull request
Jan 8, 2024
* Ports min polled period of 1 Prevent divide by 0 Use Mac utility * fix bad snmprec for airos-af-ltu * Update a large amount of invalid mac addresses either the script is capturing them wrong or users are mangling them * More updated test data * Update test data with bad input * Fix ones using encoded <private> and attempt to fix capture * Update awplus data * restore missing data * update other DNOS * Fix ones using encoded <private> and attempt to fix capture * Fix ones using encoded <private> and attempt to fix capture * fix typo * Update some data * update data * update ruijie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is an issue with the capture utility around ifPhysAddress
(also some garbage from devices of course)
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.