Fix polling down retry (and other items) #15483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because availability now runs always, we need to check if we ran any other modules successfully, if so, we can update last_polled
peejaychilds
pushed a commit
to peejaychilds/librenms
that referenced
this pull request
Oct 26, 2023
* Only update last_polled if polled Because availability now runs always, we need to check if we ran any other modules successfully, if so, we can update last_polled * Tally results and act accordingly * Apply fixes from StyleCI --------- Co-authored-by: StyleCI Bot <bot@styleci.io>
gdepeyrot
pushed a commit
to gdepeyrot/librenms
that referenced
this pull request
Nov 29, 2023
* Only update last_polled if polled Because availability now runs always, we need to check if we ran any other modules successfully, if so, we can update last_polled * Tally results and act accordingly * Apply fixes from StyleCI --------- Co-authored-by: StyleCI Bot <bot@styleci.io>
gdepeyrot
pushed a commit
to gdepeyrot/librenms
that referenced
this pull request
Nov 29, 2023
* Only update last_polled if polled Because availability now runs always, we need to check if we ran any other modules successfully, if so, we can update last_polled * Tally results and act accordingly * Apply fixes from StyleCI --------- Co-authored-by: StyleCI Bot <bot@styleci.io>
gunkaaa
pushed a commit
to gunkaaa/librenms
that referenced
this pull request
Jan 8, 2024
* Only update last_polled if polled Because availability now runs always, we need to check if we ran any other modules successfully, if so, we can update last_polled * Tally results and act accordingly * Apply fixes from StyleCI --------- Co-authored-by: StyleCI Bot <bot@styleci.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lnms device:poll was returning the wrong status code when all devices were down, breaking the retry back-off timer of the dispatcher and allowing constant retries.
Only update last_polled when the device was up.
Don't disable any graphs when the device is down.
Should be a performance increase (or restoration) for installs using the dispatcher with many down devices.
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.