Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertiv pdu mg02e4w1 #15484

Merged
merged 7 commits into from Nov 2, 2023
Merged

Conversation

Galileo77
Copy link
Contributor

@Galileo77 Galileo77 commented Oct 19, 2023

Please give a short description what your pull request is for

Detection of Vertiv Geist PDU type MG02E4W1

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Detection of Vertiv Geist PDU type MG02E4W1
Testfile for Vertiv Geist PDU MG02E4W1
@Jellyfrog Jellyfrog added the Device 🖥️ New or added device support label Oct 19, 2023
@murrant murrant changed the title Galileo77 vertiv pdu mg02e4w1 vertiv pdu mg02e4w1 Oct 20, 2023
@@ -5,6 +5,7 @@ icon: vertiv
group: vertiv
discovery:
- sysObjectID:
- .1.3.6.1.4.1.21239.42.1.52
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just these two Vertiv PDU devices? or should the sysObjectID be less specific?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have only these two types of Vertiv Geist PDUs. With the sysObjectID - .1.3.6.1.4.1.21239.42.1.53 LibreNMS recognizes only one type. The second type needs the sysObjectID -.1.3.6.1.4.1.21239.42.1.52

Copy link
Member

@murrant murrant Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but .1.3.6.1.4.1.21239.42.1. would detect both of those and more. Adding devices individually is a losing game.

The only trick is figuring out if the "more" is correct or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok i will try it on our test system this night.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both devices are recognized, no problems so far.

@murrant murrant merged commit 0fb72b3 into librenms:master Nov 2, 2023
8 checks passed
@Galileo77 Galileo77 deleted the Galileo77-vertiv-pdu-MG02E4W1 branch November 3, 2023 10:43
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-11-0-changelog/22833/1

gdepeyrot pushed a commit to gdepeyrot/librenms that referenced this pull request Nov 29, 2023
* Update vertiv-pdu.yaml

Detection of Vertiv Geist PDU type MG02E4W1

* Add files via upload

Testfile for Vertiv Geist PDU MG02E4W1

* Add files via upload

Testfile

* Update vertiv-pdu.yaml

* Update vertiv-pdu_mg02e4w1.json

* Add missing sensors from OP

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
gunkaaa pushed a commit to gunkaaa/librenms that referenced this pull request Jan 8, 2024
* Update vertiv-pdu.yaml

Detection of Vertiv Geist PDU type MG02E4W1

* Add files via upload

Testfile for Vertiv Geist PDU MG02E4W1

* Add files via upload

Testfile

* Update vertiv-pdu.yaml

* Update vertiv-pdu_mg02e4w1.json

* Add missing sensors from OP

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants