New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vertiv pdu mg02e4w1 #15484
vertiv pdu mg02e4w1 #15484
Conversation
Detection of Vertiv Geist PDU type MG02E4W1
Testfile for Vertiv Geist PDU MG02E4W1
Testfile
includes/definitions/vertiv-pdu.yaml
Outdated
@@ -5,6 +5,7 @@ icon: vertiv | |||
group: vertiv | |||
discovery: | |||
- sysObjectID: | |||
- .1.3.6.1.4.1.21239.42.1.52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just these two Vertiv PDU devices? or should the sysObjectID be less specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have only these two types of Vertiv Geist PDUs. With the sysObjectID - .1.3.6.1.4.1.21239.42.1.53 LibreNMS recognizes only one type. The second type needs the sysObjectID -.1.3.6.1.4.1.21239.42.1.52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but .1.3.6.1.4.1.21239.42.1.
would detect both of those and more. Adding devices individually is a losing game.
The only trick is figuring out if the "more" is correct or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i will try it on our test system this night.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both devices are recognized, no problems so far.
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
* Update vertiv-pdu.yaml Detection of Vertiv Geist PDU type MG02E4W1 * Add files via upload Testfile for Vertiv Geist PDU MG02E4W1 * Add files via upload Testfile * Update vertiv-pdu.yaml * Update vertiv-pdu_mg02e4w1.json * Add missing sensors from OP --------- Co-authored-by: Tony Murray <murraytony@gmail.com>
* Update vertiv-pdu.yaml Detection of Vertiv Geist PDU type MG02E4W1 * Add files via upload Testfile for Vertiv Geist PDU MG02E4W1 * Add files via upload Testfile * Update vertiv-pdu.yaml * Update vertiv-pdu_mg02e4w1.json * Add missing sensors from OP --------- Co-authored-by: Tony Murray <murraytony@gmail.com>
Please give a short description what your pull request is for
Detection of Vertiv Geist PDU type MG02E4W1
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.