Plugin update (breaking) #15498
Merged
Plugin update (breaking) #15498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple breaking changes regarding property types and method arguments. Add a setting to allow plugin errors to be shown instead of automatically disabling the plugin. All default hooks now use Dependency Injection to make it easy to get access to whatever you need (such as settings) Add a ton of comments and examples in the PHP code. Expand a bit on the documentation, it could still use more help Fix a bug in the settings and page view where the included blade file was output before the page headers, etc
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
gdepeyrot
pushed a commit
to gdepeyrot/librenms
that referenced
this pull request
Nov 29, 2023
* Plugin update (breaking) A couple breaking changes regarding property types and method arguments. Add a setting to allow plugin errors to be shown instead of automatically disabling the plugin. All default hooks now use Dependency Injection to make it easy to get access to whatever you need (such as settings) Add a ton of comments and examples in the PHP code. Expand a bit on the documentation, it could still use more help Fix a bug in the settings and page view where the included blade file was output before the page headers, etc * Apply fixes from StyleCI --------- Co-authored-by: StyleCI Bot <bot@styleci.io>
gdepeyrot
pushed a commit
to gdepeyrot/librenms
that referenced
this pull request
Nov 29, 2023
* Plugin update (breaking) A couple breaking changes regarding property types and method arguments. Add a setting to allow plugin errors to be shown instead of automatically disabling the plugin. All default hooks now use Dependency Injection to make it easy to get access to whatever you need (such as settings) Add a ton of comments and examples in the PHP code. Expand a bit on the documentation, it could still use more help Fix a bug in the settings and page view where the included blade file was output before the page headers, etc * Apply fixes from StyleCI --------- Co-authored-by: StyleCI Bot <bot@styleci.io>
gunkaaa
pushed a commit
to gunkaaa/librenms
that referenced
this pull request
Jan 8, 2024
* Plugin update (breaking) A couple breaking changes regarding property types and method arguments. Add a setting to allow plugin errors to be shown instead of automatically disabling the plugin. All default hooks now use Dependency Injection to make it easy to get access to whatever you need (such as settings) Add a ton of comments and examples in the PHP code. Expand a bit on the documentation, it could still use more help Fix a bug in the settings and page view where the included blade file was output before the page headers, etc * Apply fixes from StyleCI --------- Co-authored-by: StyleCI Bot <bot@styleci.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple breaking changes regarding property types and method arguments.
Add a setting to allow plugin errors to be shown instead of automatically disabling the plugin.
All default hooks now use Dependency Injection to make it easy to get access to whatever you need (such as settings)
Add a ton of comments and examples in the PHP code.
Expand a bit on the documentation, it could still use more help
Fix a bug in the settings and page view where the included blade file was output before the page headers, etc
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.