Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect web_mouseover setting in popup component #15530

Merged
merged 2 commits into from Oct 31, 2023

Conversation

murrant
Copy link
Member

@murrant murrant commented Oct 31, 2023

fixes #15496

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant merged commit ef12cef into librenms:master Oct 31, 2023
10 checks passed
@murrant murrant deleted the fix-popup branch October 31, 2023 15:12
tim427 pushed a commit to tim427/librenms that referenced this pull request Oct 31, 2023
* Respect web_mouseover setting in popup component
fixes librenms#15496

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-11-0-changelog/22833/1

gdepeyrot pushed a commit to gdepeyrot/librenms that referenced this pull request Nov 29, 2023
* Respect web_mouseover setting in popup component
fixes librenms#15496

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
gunkaaa pushed a commit to gunkaaa/librenms that referenced this pull request Jan 8, 2024
* Respect web_mouseover setting in popup component
fixes librenms#15496

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web_mouseover = false, not honoured
3 participants