Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device - McAfee Web Gateway -> SkyHigh Web Gateway #15596

Merged
merged 5 commits into from Dec 15, 2023

Conversation

PipoCanaja
Copy link
Contributor

@PipoCanaja PipoCanaja commented Nov 23, 2023

The product is now branded Skyhigh and they renumbered the OIDs ...

So 1st step is to identify devices running old version from new version. And then discover and poll correctly the new version.
And 2nd step was to identify the version between old and new (12.1) which is still showing a mix of both :)

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja added the Device 🖥️ New or added device support label Nov 23, 2023
@PipoCanaja PipoCanaja self-assigned this Nov 23, 2023
@PipoCanaja PipoCanaja added the Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ label Nov 23, 2023
Copy link

Please add test data so we can ensure your change is not broken in the future.
Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@PipoCanaja PipoCanaja changed the title WIP Device - McAfee -> SkyHigh WIP Device - McAfee Web Gateway -> SkyHigh Web Gateway Nov 23, 2023
@PipoCanaja PipoCanaja removed the Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ label Nov 30, 2023
@PipoCanaja PipoCanaja changed the title WIP Device - McAfee Web Gateway -> SkyHigh Web Gateway device - McAfee Web Gateway -> SkyHigh Web Gateway Nov 30, 2023
@PipoCanaja PipoCanaja added the Pending Review Pending maintainer review label Dec 2, 2023
@PipoCanaja PipoCanaja removed the Pending Review Pending maintainer review label Dec 12, 2023
@PipoCanaja PipoCanaja added this to the 23.12.0 milestone Dec 12, 2023
@murrant murrant merged commit a54a82a into librenms:master Dec 15, 2023
11 checks passed
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/24-1-0-changelog/23271/1

gunkaaa pushed a commit to gunkaaa/librenms that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants