Poller service

[clinta]

This replaces PR #1405 which was broken by the Github takedown and restore.

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://1561.ci.librenms.org or https://1561.ci.librenms.org

[spinza]

Great thanks! I had not realised that my problem was a general one! (Referring to the forks issue on github).

[laf]

:bump:

I'd like us to look at moving this forward for merging. It can be done so it's a secondary choice on how to run poller until we get more live feedback or it's perfect time for us to look at a dev branch.

@paulgear / @f0o

[f0o]

I'm pro Dev/Master branches eventhough this contradicts the rolling-release @paulgear seems to prefer.

The poller-service has my 👍 - Against all odds we should mention in the docs that people running MultiMaster MySQL setups are going to revert this commit on thier own setup due to the lock-usage in discovery.php and poller.php. I'm not aware of anybody but me doing this but silence doesnt mean that nobody does it :)

[clinta]

I can add some documentation about considerations for multi-master MySQL.

[f0o]

That'd be awesome @clinta :)

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://1561.ci.librenms.org or https://1561.ci.librenms.org

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://1561.ci.librenms.org or https://1561.ci.librenms.org

[paulgear]

With a PR as long-running as this, I'd really prefer to see it fully rebased to get rid of those merge commits.

[clinta]

Rebased in #1584