Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug - bgp-peers error in Timos -> dbFacile cleanup #15620

Merged
merged 6 commits into from Dec 18, 2023

Conversation

PipoCanaja
Copy link
Contributor

@PipoCanaja PipoCanaja commented Dec 5, 2023

Started with bgp-peers errors (DbDelete).

SQLSTATE[HY093]: Invalid parameter number (Connection: mysql, SQL: DELETE FROM `bgpPeers` WHERE device_id = 860 AND bgpPeerIdentifier = 10.136.0.1  AND `vrf_id` IS NULL ) (Connection: dbFacile, SQL: DELETE FROM `bgpPeers` WHERE device_id = 860 AND bgpPeerIdentifier = 10.136.0.1  AND `vrf_id` IS NULL )#0 /opt/librenms/includes/discovery/bgp-peers/timos.inc.php(91): dbDelete()
#1 /opt/librenms/includes/discovery/bgp-peers.inc.php(11): include('...')
#2 /opt/librenms/includes/discovery/functions.inc.php(164): include('...')
#3 /opt/librenms/discovery.php(108): discover_device()
#4 {main}  

SQLSTATE[HY093]: Invalid parameter number (Connection: mysql, SQL: DELETE FROM `bgpPeers` WHERE device_id = 860 AND bgpPeerIdentifier = 10.136.0.2  AND `vrf_id` IS NULL ) (Connection: dbFacile, SQL: DELETE FROM `bgpPeers` WHERE device_id = 860 AND bgpPeerIdentifier = 10.136.0.2  AND `vrf_id` IS NULL )#0 /opt/librenms/includes/discovery/bgp-peers/timos.inc.php(91): dbDelete()
#1 /opt/librenms/includes/discovery/bgp-peers.inc.php(11): include('...')
#2 /opt/librenms/includes/discovery/functions.inc.php(164): include('...')
#3 /opt/librenms/discovery.php(108): discover_device()
#4 {main}  

Cleaning up a few DbFacile calls to fix.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja self-assigned this Dec 5, 2023
@PipoCanaja PipoCanaja changed the title bug - bgp-peers error in Timos -> dbFacile cleanup bug - WIP bgp-peers error in Timos -> dbFacile cleanup Dec 5, 2023
@PipoCanaja PipoCanaja changed the title bug - WIP bgp-peers error in Timos -> dbFacile cleanup bug - bgp-peers error in Timos -> dbFacile cleanup Dec 5, 2023
@craig-nokia
Copy link
Contributor

Fix is verified.

@PipoCanaja PipoCanaja added Pending Review Pending maintainer review and removed Pending Review Pending maintainer review labels Dec 11, 2023
@PipoCanaja PipoCanaja added this to the 23.12.0 milestone Dec 12, 2023
@murrant murrant merged commit d9595fc into librenms:master Dec 18, 2023
10 checks passed
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/24-1-0-changelog/23271/1

gunkaaa pushed a commit to gunkaaa/librenms that referenced this pull request Jan 8, 2024
* dbFacile cleanup, step 1

* style

* tests

* tests-more

* tests

* tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants