Fixing memory scale for datacom-dmos devices #15640
Conversation
Fixing memory scale for datacom-dmos devices
|
According to the tests, it seems that it is not working. Moreover, you fixed the index to '1'. Better to use the index provided by the device in the MIB (that would allow the device to provide more than one value). |
PipoCanaja
added
the
Needs Tests 🦄
|
Please add test data so we can ensure your change is not broken in the future. |
|
@PipoCanaja, in my tests it was working. I also tested now without using the index 1 and it changed from the scale from MiB to GiB but still consistent (right values). |
Removing the line "index: 1" because the MIB shall provide the existent indexes.
Uploading updated snmprec files after changing the datacom-dmos.yaml in order to fix the memory scale.
Uploading updated json files after changing the datacom-dmos.yaml in order to fix the memory scale.
Updated datacom-dmos test files (snmprec and json). I had problems generating these files, so please ignore the commits without files I did earlier.
|
Seems that the tests went somehow wrong (all empty). Fixing that for you |
PipoCanaja
removed
the
Needs Tests 🦄
|
LGTM, so let's control the tests and it will be ready for merge |
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
* Fixing memory scale for datacom-dmos devices Fixing memory scale for datacom-dmos devices * Update datacom-dmos.yaml Removing the line "index: 1" because the MIB shall provide the existent indexes. * Uploading updated snmprec files Uploading updated snmprec files after changing the datacom-dmos.yaml in order to fix the memory scale. * Uploading updated json files Uploading updated json files after changing the datacom-dmos.yaml in order to fix the memory scale. * datacom-dmos updated snmprec files * snmprec files * Updated datacom-dmos test files (snmprec and json) Updated datacom-dmos test files (snmprec and json). I had problems generating these files, so please ignore the commits without files I did earlier. * Fix Tests --------- Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Fixing memory scale for datacom-dmos devices
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.