Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HPE iLO CPU Status Sensor Description #15660

Merged

Conversation

mtentilucci
Copy link
Contributor

Fix the HPE iLO CPU status sensor description to match the processor socket number. The CPU socket number retrieved from the cpqSeCpuSocketNumber OID matches the processor number shown in the HPE iLO web UI. It seems the previously used OID cpqSeCpuSlot always returns 0 even in systems with multiple CPU sockets.

Changes this:
librenms-hpe-processor0x2

To this:
librenms-hpe-processor-fixed

Test data files were regenerated by running ./scripts/save-test-data.php -o hpe-ilo -v ...

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@electrocret electrocret added Sensor Device sensors Device 🖥️ New or added device support and removed Sensor Device sensors labels Dec 19, 2023
Copy link
Member

@electrocret electrocret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks!

@electrocret electrocret merged commit b4a6163 into librenms:master Dec 19, 2023
11 checks passed
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/24-1-0-changelog/23271/1

gunkaaa pushed a commit to gunkaaa/librenms that referenced this pull request Jan 8, 2024
* fix processor# description

* update hpe-ilo test data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants