OSPF instances and missing mandatory fields fix attempt #15712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PipoCanaja
changed the title
vhuk
suggested changes
Jan 8, 2024
LibreNMS/Modules/Ospf.php
Outdated
| @@ -87,6 +87,11 @@ public function poll(OS $os, DataStorageInterface $datastore): void | |||
| if (empty($ospf_entry['ospfRouterId'])) { | |||
| continue; // skip invalid data | |||
| } | |||
| foreach (['ospfRxNewLsas', 'ospfOriginateNewLsas', 'ospfAreaBdrRtrStatus', 'ospfExternLsaCount', 'ospfTOSSupport', 'ospfExternLsaCksumSum', 'ospfExternLsaCount', 'ospfASBdrRtrStatus', 'ospfVersionNumber', 'ospfAdminStat'] as $column) { | |||
There was a problem hiding this comment.
ospfExternLsaCount is twice on the list
There was a problem hiding this comment.
On my way to fix that. I suppose double check is not necessary 🤣 Did you check it in your instance to confirm the issue is gone ?
vhuk
suggested changes
Jan 8, 2024
vhuk
approved these changes
Jan 8, 2024
|
Great, then ready for review ! |
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of columns that cannot be NULL, so we need to check that before trying to createOrUpdate
fixes #15701
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.