Add support for Webex max message length. #15789
Conversation
Webex limits messages to just over 7 KB. Some alerts might be longer than this. So truncate the message with ellipses. While here switch to using the new API URL.
|
|
Formatting got messed up on the transfer from test to dev.
| $data = [ | ||
| 'roomId' => $room_id, | ||
| ]; | ||
|
|
||
| if (strlen($alert_data['msg']) > Ciscospark::$MAX_MSG_SIZE) { |
There was a problem hiding this comment.
Hi @xorrkaz
You should probably move the truncate code after the block that removes blank lines, and tags.
There was a problem hiding this comment.
[Face palm]. Yup. Good call!
This may yield a few more allowed characters.
|
Hi @xorrkaz |
Saw that, did you? Yep. Worked out very well for us. As always. |
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
Webex limits messages to just over 7 KB. Some alerts might be longer than this. So truncate the message with ellipses.
While here switch to using the new API URL.
Please give a short description what your pull request is for
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.