Add HSRP state sensors for Cisco IOS on L3 switches

[rudybroersma]

This patch contains an addition to the IOS discovery YAML to add HSRP state sensor support.

eg:
sample 1:

sample 2:

This allows LibreNMS to detect HSRP changes in the network

My Cisco lab consists of Catalyst 3560 switches.

Special thanks to Christiaan de Jonge :)

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

• Have you followed our code guidelines?
• If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
• If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

[github-actions]

Please add test data so we can ensure your change is not broken in the future.
Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

[rudybroersma]

@electrocret Tests done!

[PipoCanaja]

Hi @rudybroersma
Looks good to me. Might be a little bit verbose on bigger chassis with a lot of Vlan Interfaces but it can be filtered by the users.

That being said, I think it would make sense to go a little bit further and create a dedicated module for HSRP/VRRP/etc that would complement the port page and replace these sensors.

[PipoCanaja]

LGTM

[rudybroersma]

Hi @rudybroersma Looks good to me. Might be a little bit verbose on bigger chassis with a lot of Vlan Interfaces but it can be filtered by the users.

That being said, I think it would make sense to go a little bit further and create a dedicated module for HSRP/VRRP/etc that would complement the port page and replace these sensors.

Alright, just so I get this right.. You mean a new page in the tabs like Overview, Graph, Ports, VLANs, Neighbors, STP and alike?

I'll work on that, but might take me a while. Limited free time and all. If in the meantime this PR can be approved that would be great, I'll remove this sensor when my new code is ready.

[PipoCanaja]

Hi @rudybroersma Looks good to me. Might be a little bit verbose on bigger chassis with a lot of Vlan Interfaces but it can be filtered by the users.
That being said, I think it would make sense to go a little bit further and create a dedicated module for HSRP/VRRP/etc that would complement the port page and replace these sensors.

Alright, just so I get this right.. You mean a new page in the tabs like Overview, Graph, Ports, VLANs, Neighbors, STP and alike?

2 angles:

• For discovery, polling, creation of a new module, could be named "FHRP" to handle all the 1st hop redundancy protocols. (https://en.wikipedia.org/wiki/First-hop_redundancy_protocol).
• For GUI, anywhere needed this information could be added, as soon as it is stored in the DB

I'll work on that, but might take me a while. Limited free time and all. If in the meantime this PR can be approved that would be great, I'll remove this sensor when my new code is ready.

Yep, sounds good.

[librenms-bot]

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/24-2-0-changelog/23721/1