Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAMLized version of previous PR for Ericsson SSR 80xx routers #15834

Merged
merged 18 commits into from Feb 28, 2024

Conversation

rudybroersma
Copy link
Contributor

@rudybroersma rudybroersma commented Feb 17, 2024

Per community request I made a PR for Ericsson SSR 80xx routers before:
#15797
https://community.librenms.org/t/please-add-new-os-ericsson-ipos-device-ssr-8010-ssr-8020/

@PipoCanaja suggested that this could also be done in YAML instead of PHP and did most of the work getting this to work :)

Here's the new YAMLized version.

As far as I could tell there's no way to add storage sensors using YAML so those are still in PHP. If I'm missing something please let me know.

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@rudybroersma rudybroersma marked this pull request as ready for review February 17, 2024 21:33
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/please-add-new-os-ericsson-ipos-device-ssr-8010-ssr-8020/22300/12

@PipoCanaja PipoCanaja added the Device 🖥️ New or added device support label Feb 17, 2024
includes/discovery/storage/ericsson-ipos.inc.php Outdated Show resolved Hide resolved
includes/polling/storage/ericsson-ipos.inc.php Outdated Show resolved Hide resolved
Copy link
Member

@electrocret electrocret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The YAML & Code look good.

Are all the MIB files necessary? We try to keep the MIB directories as close to just the MIBs that are being used.

@rudybroersma
Copy link
Contributor Author

The YAML & Code look good.

Are all the MIB files necessary? We try to keep the MIB directories as close to just the MIBs that are being used.

MIBs have been cleaned up!

Copy link
Member

@electrocret electrocret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@electrocret electrocret merged commit d456e78 into librenms:master Feb 28, 2024
8 checks passed
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/24-3-0-changelog/24000/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants