New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAMLized version of previous PR for Ericsson SSR 80xx routers #15834
YAMLized version of previous PR for Ericsson SSR 80xx routers #15834
Conversation
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/please-add-new-os-ericsson-ipos-device-ssr-8010-ssr-8020/22300/12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The YAML & Code look good.
Are all the MIB files necessary? We try to keep the MIB directories as close to just the MIBs that are being used.
MIBs have been cleaned up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
Per community request I made a PR for Ericsson SSR 80xx routers before:
#15797
https://community.librenms.org/t/please-add-new-os-ericsson-ipos-device-ssr-8010-ssr-8020/
@PipoCanaja suggested that this could also be done in YAML instead of PHP and did most of the work getting this to work :)
Here's the new YAMLized version.
As far as I could tell there's no way to add storage sensors using YAML so those are still in PHP. If I'm missing something please let me know.
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.