Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #15952

Merged
merged 1 commit into from Apr 18, 2024
Merged

Fix typo #15952

merged 1 commit into from Apr 18, 2024

Conversation

Taarek
Copy link
Contributor

@Taarek Taarek commented Apr 18, 2024

Fixed a typo Backlog Lenght -> Backlog Length

I noticed this typo underneath Devices -> [Device] -> Apps -> Linux SoftNet Stats and wanted to fix it.
I also noticed there is a similar typo in a mib file here:

"ACC send packet to master with reason IP lenght > 40, this means a packet with data"

But I'll be honest, I am not good with SNMP/MIBs, maybe it has to be a typo in that MIB file, to be able to parse the description.
If it's fine to fix, lmk and I'll push another commit addressing this.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Fixed a typo `Backlog Lenght` -> `Backlog Length`
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@Jellyfrog Jellyfrog changed the title Fix typo in linux_softnet_static.inc.php Fix typo Apr 18, 2024
@Jellyfrog Jellyfrog merged commit 4cce4f0 into librenms:master Apr 18, 2024
8 checks passed
@murrant
Copy link
Member

murrant commented Apr 19, 2024

We generally don't edit MIB files. When they get updated the new ones just replace them anyway. Thanks for the typo fix!

@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/24-4-0-changelog/24157/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants