Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved sensors for the Panduit PDU device. #15975

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

kruczek8989
Copy link
Contributor

Adding temperature and humidity sensors for the Panduit PDU device.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@Jellyfrog Jellyfrog added Device 🖥️ New or added device support Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ labels Apr 24, 2024
Copy link

Please add test data so we can ensure your change is not broken in the future.
Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@kruczek8989
Copy link
Contributor Author

Adding support for Huawei switches with YunShan software - is another version of the same VRP.

@kruczek8989
Copy link
Contributor Author

kruczek8989 commented Apr 25, 2024

Please add test data so we can ensure your change is not broken in the future. Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

Which specific files from the performed tests should I attach?

--
Update
Ok, I've got it figured out.
Attached are the test files.
panduit.json

@murrant
Copy link
Member

murrant commented May 19, 2024

You are missing either an updated snmprec or additional snmprec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants