Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGNL4 Alert Transport #16037

Merged
merged 3 commits into from
May 22, 2024
Merged

SIGNL4 Alert Transport #16037

merged 3 commits into from
May 22, 2024

Conversation

rons4
Copy link
Contributor

@rons4 rons4 commented May 15, 2024

Please give a short description what your pull request is for

This PR adds SIGNL4 as an alert transport to LibreNMS. You can find more information here:
https://docs.signl4.com/integrations/librenms/librenms.html

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • [x ] Have you followed our code guidelines?
  • [x ] If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • [x ] If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Screenshots can be found here: https://docs.signl4.com/integrations/librenms/librenms.html

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant
Copy link

CLAassistant commented May 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@electrocret electrocret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@electrocret electrocret merged commit 79184e8 into librenms:master May 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants