-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Suricata 7 support to Suricata #16044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not anything specific but because there are so many variables, some of this is hard to read. Try to minimize the amount of scrolling to figure out what something is. For example, setting a bunch of variables at the top of the file only to use them once at the bottom makes it harder to read the code.
Definitely change the strcmp to == or === instead.
hmmm.... Extract bits of it to it's own files and the graph file contains a array that is used for dynamically building that all |
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
Suricata 7 is the current version of Suricata and this extend really needs updated for it.
todo..
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.