Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Suricata 7 support to Suricata #16044

Merged
merged 108 commits into from
Jun 10, 2024
Merged

add Suricata 7 support to Suricata #16044

merged 108 commits into from
Jun 10, 2024

Conversation

VVelox
Copy link
Contributor

@VVelox VVelox commented May 20, 2024

Suricata 7 is the current version of Suricata and this extend really needs updated for it.

todo..

  • new test for v2 of the extend
  • update docs

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@VVelox VVelox marked this pull request as ready for review June 2, 2024 23:16
Copy link
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not anything specific but because there are so many variables, some of this is hard to read. Try to minimize the amount of scrolling to figure out what something is. For example, setting a bunch of variables at the top of the file only to use them once at the bottom makes it harder to read the code.

Definitely change the strcmp to == or === instead.

includes/html/pages/device/apps/suricata.inc.php Outdated Show resolved Hide resolved
@VVelox
Copy link
Contributor Author

VVelox commented Jun 5, 2024

Not anything specific but because there are so many variables, some of this is hard to read. Try to minimize the amount of scrolling to figure out what something is. For example, setting a bunch of variables at the top of the file only to use them once at the bottom makes it harder to read the code.

hmmm.... Extract bits of it to it's own files and the graph file contains a array that is used for dynamically building that all

@murrant murrant merged commit 572258e into librenms:master Jun 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants