Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlertOps alert transport #16050

Merged
merged 3 commits into from
May 23, 2024
Merged

AlertOps alert transport #16050

merged 3 commits into from
May 23, 2024

Conversation

ashwath129
Copy link
Contributor

This is a request to add this Transport publicly, so alerts can be sent to AlertOps' webhook endpoint - AlertOps is an alerting/notification tool. (https://alertops.com/)

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

This is a request to add this Transport publicly, so alerts can be sent to AlertOps' webhook endpoint - AlertOps is an alerting/notification tool.
@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@electrocret electrocret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation to doc/Alerting/Transports.md on how to configure this Alert Transport.

@ashwath129
Copy link
Contributor Author

Please add documentation to doc/Alerting/Transports.md on how to configure this Alert Transport.

Sure did this ! - #16058

@murrant
Copy link
Member

murrant commented May 23, 2024

@ashwath129 can you please put the docs in this PR (that way it is easy to find them later).
If you don't know how to do that, come ask on Discord.

@electrocret electrocret merged commit c770892 into librenms:master May 23, 2024
8 checks passed
@electrocret
Copy link
Member

@murrant , sorry didn't see your comment before approving these.

Yeah, it's best practice to have all the changes under a single PR, however in this instance it shouldn't be too much of an inconvenience since it's just a single transport that doesn't seem to have anything out of the ordinary going on.

@murrant murrant changed the title Create Alertops.php AlertOps alert transport Jun 16, 2024
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/24-6-0-changelog/24707/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants