Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the buttons (Edit and Delete) to the right in Map Management #16052

Merged
merged 1 commit into from
May 22, 2024

Conversation

santiag0z
Copy link
Contributor

Please give a short description what your pull request is for
Before
image
image

After
image
image

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@electrocret electrocret merged commit d4b7dbe into librenms:master May 22, 2024
8 checks passed
@murrant
Copy link
Member

murrant commented May 22, 2024

If you want this change, you should limit the width of the panel.

image

@santiag0z
Copy link
Contributor Author

Hi,

image

image

@santiag0z santiag0z deleted the patch-5 branch May 22, 2024 11:44
@murrant
Copy link
Member

murrant commented May 22, 2024

@santiag0z yes, I set it intentionally like that so the buttons didn't get too far away from the label.

@murrant
Copy link
Member

murrant commented May 22, 2024

My snip was misleading this is what I'm saying:
image

Only it gets worse with more than 2 maps ;)

@murrant
Copy link
Member

murrant commented May 22, 2024

maybe a better fix was to change it from sm: to md:

@murrant murrant mentioned this pull request May 22, 2024
3 tasks
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/24-6-0-changelog/24707/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants