Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change port pagination default to 32 #16131

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Conversation

murrant
Copy link
Member

@murrant murrant commented Jun 17, 2024

that way this includes all ports for most switches. Most port counts are base 2, so change pagination options to match

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

that way this includes all ports for most switches.
Most port counts are base 2, so change pagination options to match
@murrant murrant added the WebUI label Jun 17, 2024
@murrant murrant merged commit 592ea1c into librenms:master Jun 17, 2024
6 of 8 checks passed
@Jellyfrog
Copy link
Member

@murrant murrant deleted the ports-pagination branch June 19, 2024 04:59
@murrant
Copy link
Member Author

murrant commented Jun 25, 2024

@Jellyfrog the config definitions was an accidental include, and I removed it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants