Canon printer support #2687

Merged
merged 4 commits into from Jan 4, 2016

Projects

None yet

4 participants

@mightea
Contributor
mightea commented Jan 2, 2016

Added support for canon MF-Series printers

mightea added some commits Jan 2, 2016
@mightea mightea added support for canon MF-series printers b9ced65
@mightea mightea signed contribution agreement
I agree to the conditions of the Contributor Agreement
contained in doc/General/Contributing.md.
fec12d3
@f0o
Member
f0o commented Jan 2, 2016

No polling code required?

@mightea
Contributor
mightea commented Jan 3, 2016

No, the current printer snmp presets work fine for toner levels, detection was the main problem.

@mightea mightea added polling for canon printers
5d410ae
@mightea
Contributor
mightea commented Jan 3, 2016

added polling for firmware-version serial number and hardware

@laf
Member
laf commented Jan 4, 2016

Can you rename includes/discovery/os/canon-printer.inc.php to includes/discovery/os/canonprinter.inc.php so it's consistent with the rest of the naming convention then we can merge.

@mightea mightea renamed canon-printer discovery module
388981d
@laf laf merged commit 3c72b68 into librenms:master Jan 4, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
@mightea mightea deleted the fiveninedigital:canon-printer branch Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment