Canon printer support #2687
Merged
Canon printer support #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 2, 2016 17:42
I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md.
|
Auto-Deploy finished, Test PR at http://2687.ci.librenms.org or https://2687.ci.librenms.org |
|
No polling code required? |
|
No, the current printer snmp presets work fine for toner levels, detection was the main problem. |
|
Auto-Deploy finished, Test PR at http://2687.ci.librenms.org or https://2687.ci.librenms.org |
|
added polling for firmware-version serial number and hardware |
|
Can you rename includes/discovery/os/canon-printer.inc.php to includes/discovery/os/canonprinter.inc.php so it's consistent with the rest of the naming convention then we can merge. |
|
Auto-Deploy finished, Test PR at http://2687.ci.librenms.org or https://2687.ci.librenms.org |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for canon MF-Series printers