Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated discovery sensors module directory structure #2794

Merged
merged 2 commits into from
Jan 19, 2016

Conversation

laf
Copy link
Member

@laf laf commented Jan 17, 2016

This has annoyed me for long enough now!

The includes/discovery/ directory should contain the core discovery files with all of the code relevant to those in sub directories. Before this change all sensors files were scattered within here, these have now been moved to includes/discovery/sensors/

Everything needed should be updated ok.

@laf laf added the Core label Jan 17, 2016
@f0o
Copy link
Member

f0o commented Jan 19, 2016

trigger ci

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://2794.ci.librenms.org or https://2794.ci.librenms.org

@Rosiak
Copy link
Member

Rosiak commented Jan 19, 2016

👍
No issues on dev machine.

require 'includes/discovery/sensors/power.inc.php';
require 'includes/discovery/sensors/fanspeeds.inc.php';
require 'includes/discovery/sensors/charge.inc.php';
require 'includes/discovery/sensors/load.inc.php';
require 'includes/discovery/states.inc.php';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should also be updated to the new sensors folder.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted. Updated.

@laf
Copy link
Member Author

laf commented Jan 19, 2016

trigger ci

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://2794.ci.librenms.org or https://2794.ci.librenms.org

1 similar comment
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://2794.ci.librenms.org or https://2794.ci.librenms.org

SaaldjorMike added a commit that referenced this pull request Jan 19, 2016
Updated discovery sensors module directory structure
@SaaldjorMike SaaldjorMike merged commit dfc3210 into librenms:master Jan 19, 2016
@laf laf deleted the sensors-cleanup branch January 19, 2016 22:29
@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants