Updated discovery sensors module directory structure #2794

Merged
merged 2 commits into from Jan 19, 2016

Projects

None yet

5 participants

@laf
Member
laf commented Jan 17, 2016

This has annoyed me for long enough now!

The includes/discovery/ directory should contain the core discovery files with all of the code relevant to those in sub directories. Before this change all sensors files were scattered within here, these have now been moved to includes/discovery/sensors/

Everything needed should be updated ok.

@laf laf Updated discovery sensors module directory structure
b5d1155
@laf laf added the Core label Jan 17, 2016
@f0o
Member
f0o commented Jan 19, 2016

trigger ci

@Rosiak
Contributor
Rosiak commented Jan 19, 2016

👍
No issues on dev machine.

@SaaldjorMike SaaldjorMike and 1 other commented on an outdated diff Jan 19, 2016
includes/discovery/sensors.inc.php
-require 'includes/discovery/voltages.inc.php';
-require 'includes/discovery/frequencies.inc.php';
-require 'includes/discovery/current.inc.php';
-require 'includes/discovery/power.inc.php';
-require 'includes/discovery/fanspeeds.inc.php';
-require 'includes/discovery/charge.inc.php';
-require 'includes/discovery/load.inc.php';
+require 'includes/discovery/sensors/temperatures.inc.php';
+require 'includes/discovery/sensors/humidity.inc.php';
+require 'includes/discovery/sensors/voltages.inc.php';
+require 'includes/discovery/sensors/frequencies.inc.php';
+require 'includes/discovery/sensors/current.inc.php';
+require 'includes/discovery/sensors/power.inc.php';
+require 'includes/discovery/sensors/fanspeeds.inc.php';
+require 'includes/discovery/sensors/charge.inc.php';
+require 'includes/discovery/sensors/load.inc.php';
require 'includes/discovery/states.inc.php';
@SaaldjorMike
SaaldjorMike Jan 19, 2016 Member

Looks like this should also be updated to the new sensors folder.

@laf
laf Jan 19, 2016 Member

Well spotted. Updated.

@laf
Member
laf commented Jan 19, 2016

trigger ci

@laf laf Updated missing states sensor dir change
aea5c3f
@SaaldjorMike SaaldjorMike merged commit dfc3210 into librenms:master Jan 19, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 129 new issues
Details
@laf laf deleted the laf:sensors-cleanup branch Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment