Discoverying and polling vrf #Issue280

[h3n0c]

Trying again to add vrf-life adaptation, made by @nicearma.

On this pull request, there is no visual, only code for discoverying and polling vrf-lite :

sql-schema

adding vrf_lite_cisco table, and context name columns for some tables

mibs for work with VRF-Lite

CISCO-BRIDGE-DOMAIN-MIB and CISCO-CONTEXT-MAPPING-MIB 

discovery :

arp-table to work with vrf-lite context (sql changes and foreach for search with the device context array)
bgp-peers for work with vrf-lite context (sql changes and foreach for search with the device context array)
function for work with vrf-lite (sql changes and foreach for search with the device context array)
ipv4-addresses for work with vrf-lite (sql changes and foreach for search with the device context array)
ipv6-addresses for work with vrf-lite (sql changes and foreach for search with the device context array)

polling :

bgp-peers change for work with vrf-lite context and change to librenms logic (no more `` for execute the code, the code now the librenms function for this) and serveral logic fix
ospf change for work with vrf-lite context and change to librenms logic and serveral logic fix

other modifications :

snmp add context if SNMP v3 and if the device have the key context_name (very important!! for work with vrf-lite context)
poller add the vrf-lite array to the device
default add discovery module to the $config array

I will check for rebase regularly. Thanks for reading

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

[laf]

Can you align this config item with the others please.

[laf]

I've made some inline comments here. Once those have been updated then you have my 👍

Whilst I can't test vrf lite, I can confirm this doesn't break anything Cisco wise.

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

[laf]

If you can update your sql-schema file to 101.sql then we should be good for a merge.

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

[laf]

Re-started scrut check.

[h3n0c]

@laf I don't understand your last message

[laf]

@henocka Scrutinizer which does code check didn't run, I've restarted it that's all.

[laf]

You've got a php error, can you take a look: https://scrutinizer-ci.com/g/librenms/librenms/inspections/a1f71613-411e-4215-b1ab-3b05ce802f76/issues/files/includes/discovery/functions.inc.php?status=new&orderField=path&order=asc&honorSelectedPaths=0

[h3n0c]

Thanks, i fix this

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

[laf]

👍 from me.

@librenms/reviewers tagging. Merge in 24 hours.

[laf]

Really sorry but this has a merge conflict because of the bgp-peers update we did yesterday. Can you rebase and push an update. We can merge asap at that stage.

[h3n0c]

I update the bgp-peers :)

Le ven. 12 févr. 2016 16:20, Neil Lathwood notifications@github.com a
écrit :

Really sorry but this has a merge conflict because of the bgp-peers update
we did yesterday. Can you rebase and push an update. We can merge asap at
that stage.

—
Reply to this email directly or view it on GitHub
#2820 (comment).

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

[nicearma]

@henocka Congrats

[h3n0c]

Thanks @nicearma !
Tu as fait du bon boulot. Merci

[laf]

FYI we've had to revert some of the code in includes/polling/bgp-peers.inc.php as it was affecting junos ipv6 peers.

#3011 and #3010

[laf]

We've had to do another revert #3028 from this PR.