New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discoverying and polling vrf #Issue280 #2820

Merged
merged 47 commits into from Feb 15, 2016

Conversation

Projects
None yet
6 participants
@HenocKA
Contributor

HenocKA commented Jan 20, 2016

Trying again to add vrf-life adaptation, made by @nicearma.

On this pull request, there is no visual, only code for discoverying and polling vrf-lite :

sql-schema
adding vrf_lite_cisco table, and context name columns for some tables
mibs for work with VRF-Lite
CISCO-BRIDGE-DOMAIN-MIB and CISCO-CONTEXT-MAPPING-MIB 
discovery :
arp-table to work with vrf-lite context (sql changes and foreach for search with the device context array)
bgp-peers for work with vrf-lite context (sql changes and foreach for search with the device context array)
function for work with vrf-lite (sql changes and foreach for search with the device context array)
ipv4-addresses for work with vrf-lite (sql changes and foreach for search with the device context array)
ipv6-addresses for work with vrf-lite (sql changes and foreach for search with the device context array)
polling :
bgp-peers change for work with vrf-lite context and change to librenms logic (no more `` for execute the code, the code now the librenms function for this) and serveral logic fix
ospf change for work with vrf-lite context and change to librenms logic and serveral logic fix
other modifications :
snmp add context if SNMP v3 and if the device have the key context_name (very important!! for work with vrf-lite context)
poller add the vrf-lite array to the device
default add discovery module to the $config array

I will check for rebase regularly. Thanks for reading

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jan 20, 2016

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jan 22, 2016

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

Show outdated Hide outdated includes/defaults.inc.php
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jan 24, 2016

Member

I've made some inline comments here. Once those have been updated then you have my 👍

Whilst I can't test vrf lite, I can confirm this doesn't break anything Cisco wise.

Member

laf commented Jan 24, 2016

I've made some inline comments here. Once those have been updated then you have my 👍

Whilst I can't test vrf lite, I can confirm this doesn't break anything Cisco wise.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jan 25, 2016

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

@f0o

This comment has been minimized.

Show comment
Hide comment
@f0o

f0o Feb 7, 2016

Member

Schema 97 is still being used in this PR....

Member

f0o commented Feb 7, 2016

Schema 97 is still being used in this PR....

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 7, 2016

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 8, 2016

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 9, 2016

Member

If you can update your sql-schema file to 101.sql then we should be good for a merge.

Member

laf commented Feb 9, 2016

If you can update your sql-schema file to 101.sql then we should be good for a merge.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 10, 2016

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 10, 2016

Member

Re-started scrut check.

Member

laf commented Feb 10, 2016

Re-started scrut check.

@HenocKA

This comment has been minimized.

Show comment
Hide comment
@HenocKA

HenocKA Feb 10, 2016

Contributor

@laf I don't understand your last message

Contributor

HenocKA commented Feb 10, 2016

@laf I don't understand your last message

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 10, 2016

Member

@HenocKA Scrutinizer which does code check didn't run, I've restarted it that's all.

Member

laf commented Feb 10, 2016

@HenocKA Scrutinizer which does code check didn't run, I've restarted it that's all.

@HenocKA

This comment has been minimized.

Show comment
Hide comment
@HenocKA

HenocKA Feb 10, 2016

Contributor

Thanks, i fix this

Contributor

HenocKA commented Feb 10, 2016

Thanks, i fix this

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 10, 2016

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

@laf laf added Polling Discovery and removed Blocker 🚫 labels Feb 10, 2016

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 11, 2016

Member

👍 from me.

@librenms/reviewers tagging. Merge in 24 hours.

Member

laf commented Feb 11, 2016

👍 from me.

@librenms/reviewers tagging. Merge in 24 hours.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 12, 2016

Member

Really sorry but this has a merge conflict because of the bgp-peers update we did yesterday. Can you rebase and push an update. We can merge asap at that stage.

Member

laf commented Feb 12, 2016

Really sorry but this has a merge conflict because of the bgp-peers update we did yesterday. Can you rebase and push an update. We can merge asap at that stage.

@HenocKA

This comment has been minimized.

Show comment
Hide comment
@HenocKA

HenocKA Feb 14, 2016

Contributor

I update the bgp-peers :)

Le ven. 12 févr. 2016 16:20, Neil Lathwood notifications@github.com a
écrit :

Really sorry but this has a merge conflict because of the bgp-peers update
we did yesterday. Can you rebase and push an update. We can merge asap at
that stage.


Reply to this email directly or view it on GitHub
#2820 (comment).

Contributor

HenocKA commented Feb 14, 2016

I update the bgp-peers :)

Le ven. 12 févr. 2016 16:20, Neil Lathwood notifications@github.com a
écrit :

Really sorry but this has a merge conflict because of the bgp-peers update
we did yesterday. Can you rebase and push an update. We can merge asap at
that stage.


Reply to this email directly or view it on GitHub
#2820 (comment).

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 14, 2016

Auto-Deploy finished, Test PR at http://2820.ci.librenms.org or https://2820.ci.librenms.org

laf added a commit that referenced this pull request Feb 15, 2016

Merge pull request #2820 from HenocKA/issue280
Discoverying and polling vrf #Issue280

@laf laf merged commit a572bc4 into librenms:master Feb 15, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 21 new issues
Details
@nicearma

This comment has been minimized.

Show comment
Hide comment
@nicearma

nicearma Feb 15, 2016

Contributor

@HenocKA Congrats

Contributor

nicearma commented Feb 15, 2016

@HenocKA Congrats

@HenocKA

This comment has been minimized.

Show comment
Hide comment
@HenocKA

HenocKA Feb 15, 2016

Contributor

Thanks @nicearma !
Tu as fait du bon boulot. Merci

Contributor

HenocKA commented Feb 15, 2016

Thanks @nicearma !
Tu as fait du bon boulot. Merci

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 16, 2016

Member

FYI we've had to revert some of the code in includes/polling/bgp-peers.inc.php as it was affecting junos ipv6 peers.

#3011 and #3010

Member

laf commented Feb 16, 2016

FYI we've had to revert some of the code in includes/polling/bgp-peers.inc.php as it was affecting junos ipv6 peers.

#3011 and #3010

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 17, 2016

Member

We've had to do another revert #3028 from this PR.

Member

laf commented Feb 17, 2016

We've had to do another revert #3028 from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment