Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Added show/hide line numbers button to show config page" #3005

Closed
wants to merge 1 commit into from

Conversation

murrant
Copy link
Member

@murrant murrant commented Feb 14, 2016

Reverts #2988

Not needed, the line numbers do not inhibit the ability to copy and paste configs.

@laf
Copy link
Member

laf commented Feb 14, 2016

I believe the line numbers not being copied is a browser / text editor feature. Some will paste the number some won't. I don't believe this should be reverted.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://3005.ci.librenms.org or https://3005.ci.librenms.org

@murrant
Copy link
Member Author

murrant commented Feb 15, 2016

Ok, I only tested in Chrome, Firefox and IE 9. It is fine to leave in I just don't like to add unnecessary things.

@laf laf closed this Feb 15, 2016
@murrant murrant deleted the revert-2988-issue-2947 branch March 9, 2016 15:00
@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants