Proper State Monitoring #3102

Merged
merged 8 commits into from Feb 27, 2016

Projects

None yet

3 participants

@Rosiak
Contributor
Rosiak commented Feb 26, 2016

#2694, #1365, #1236

First attempt of making a more useable state monitoring system.
Many thanks to @vpsman for the initial code ( https://github.com/vpsman/librenms/commits/issue-2694 ), I hacked my way through the last bits & bobs.

screen shot 2016-02-26 at 23 24 59

screen shot 2016-02-26 at 23 48 51

ToDo:

  • Add more states(Only for Cisco power supply atm.)
  • Create a state overview page(Current empty)
  • Convert old state values, this implementation breaks the overlib stuff(But I have yet to hear anyone actively using /states...)
  • Be able to not draw a graph
@Rosiak Rosiak Proper State Monitoring
928fd70
@Rosiak Rosiak Add license stuff..
687bedf
@Rosiak Rosiak Scrut fix
d030e95
@laf
Member
laf commented Feb 27, 2016

Got it on my local install testing away.

  1. I think we need some docs to help people write state sensor modules.
  2. Going to: /health/metric=state/ from the Main navbar leads to a blank page where as going to /device/device=18/tab=health/metric=state/ shows the single state I have for my switch.

Let me know if I can help.

@Rosiak Rosiak Added more sensors
ebe9154
@Rosiak
Contributor
Rosiak commented Feb 27, 2016

Added more sensors, here's output from a 4500X
screen shot 2016-02-27 at 02 43 06

@Rosiak
Contributor
Rosiak commented Feb 27, 2016

@laf

  1. Yeah agree.
  2. Yup, as stated in the PR text(Top), the current page is empty. I imagine using the template from temps etc. should be fairly easy.
@laf
Member
laf commented Feb 27, 2016

Brill :)

Also, needs high / low limits in function sensor_limit(). Maybe use the state_translations table.

@Rosiak Rosiak A few things
ucwords = happy ocd

Basic state page

Allign order = happy ocd
6923a32
@Rosiak Rosiak More updates
Add sensor_prev to be able to alert on state change

Add docs
73149f3
@Rosiak Rosiak Check if it exists in table before inserting
5a831c6
@Rosiak Rosiak Scrut fix
f298ccb
@laf laf merged commit 2bf9fa1 into librenms:master Feb 27, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
@Rosiak Rosiak deleted the Rosiak:state-monitoring branch Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment