Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper State Monitoring #3102

Merged
merged 8 commits into from Feb 27, 2016
Merged

Proper State Monitoring #3102

merged 8 commits into from Feb 27, 2016

Conversation

Rosiak
Copy link
Member

@Rosiak Rosiak commented Feb 26, 2016

#2694, #1365, #1236

First attempt of making a more useable state monitoring system.
Many thanks to @vpsman for the initial code ( https://github.com/vpsman/librenms/commits/issue-2694 ), I hacked my way through the last bits & bobs.

screen shot 2016-02-26 at 23 24 59

screen shot 2016-02-26 at 23 48 51

ToDo:

  • Add more states(Only for Cisco power supply atm.)
  • Create a state overview page(Current empty)
  • Convert old state values, this implementation breaks the overlib stuff(But I have yet to hear anyone actively using /states...)
  • Be able to not draw a graph

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://3102.ci.librenms.org or https://3102.ci.librenms.org

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://3102.ci.librenms.org or https://3102.ci.librenms.org

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://3102.ci.librenms.org or https://3102.ci.librenms.org

@laf
Copy link
Member

laf commented Feb 27, 2016

Got it on my local install testing away.

  1. I think we need some docs to help people write state sensor modules.
  2. Going to: /health/metric=state/ from the Main navbar leads to a blank page where as going to /device/device=18/tab=health/metric=state/ shows the single state I have for my switch.

Let me know if I can help.

@Rosiak
Copy link
Member Author

Rosiak commented Feb 27, 2016

Added more sensors, here's output from a 4500X
screen shot 2016-02-27 at 02 43 06

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://3102.ci.librenms.org or https://3102.ci.librenms.org

@Rosiak
Copy link
Member Author

Rosiak commented Feb 27, 2016

@laf

  1. Yeah agree.
  2. Yup, as stated in the PR text(Top), the current page is empty. I imagine using the template from temps etc. should be fairly easy.

@laf
Copy link
Member

laf commented Feb 27, 2016

Brill :)

Also, needs high / low limits in function sensor_limit(). Maybe use the state_translations table.

@Rosiak
A few things
6923a32 
ucwords = happy ocd

Basic state page

Allign order = happy ocd
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://3102.ci.librenms.org or https://3102.ci.librenms.org

@Rosiak
More updates
73149f3 
Add sensor_prev to be able to alert on state change

Add docs
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://3102.ci.librenms.org or https://3102.ci.librenms.org

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://3102.ci.librenms.org or https://3102.ci.librenms.org

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://3102.ci.librenms.org or https://3102.ci.librenms.org

laf added a commit that referenced this pull request Feb 27, 2016
@laf
Merge pull request #3102 from Rosiak/state-monitoring
2bf9fa1 
Proper State Monitoring
@laf laf merged commit 2bf9fa1 into librenms:master Feb 27, 2016
@Rosiak Rosiak mentioned this pull request Mar 11, 2016
Closed
@Rosiak Rosiak deleted the state-monitoring branch February 5, 2017 14:40
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Discovery Feature WebUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rosiak @LibreNMS-CI @laf @murrant