Order alerts by state so that we can indicate rules which have triggered #3692

Merged
merged 1 commit into from Jun 22, 2016

Projects

None yet

3 participants

@laf
Member
laf commented Jun 20, 2016

Fix #3105

@laf laf Order alerts by state so that we can indicate rules which have triggered
04778ea
@murrant
Contributor
murrant commented Jun 21, 2016

Is it intended to change both state 1 and 2 to have an error visibility?

@laf
Member
laf commented Jun 21, 2016

Yes, we only pick one alert to decide what to display, sorting by state desc means we always get an ack alert regardless of having others that are alerting but not ack'd so I've chosen to just display ack / alerts as errors.

@murrant murrant merged commit 90565f7 into librenms:master Jun 22, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf deleted the laf:issue-3105 branch Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment