Unifi Wireless Client statistics #4772

merged 6 commits into from Oct 11, 2016


None yet

3 participants

jquagga commented Oct 11, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

As suggested by @laf in #4266, this adds wireless client counts to Gen2 Unifi UAPs which have the most recent firmware applied. While I ran through the pre-commit php check and other checks, I think this needs another conditional before being applied. Unifi will have APs which do not support, as well as switchs / routers / etc which have no wifi at all. I wasn't sure what conditional would be appropriate here; while there are presently 3 hardware devices which support this, more will probably be added going forward. I would think it could be possible to check to see if oid . is populated. If it is, poll for the clients and if not, don't! But, I'm not enough of an expert on this to know really :-)

I also wasn't sure if "radio0" / "radio1" were appropriate. I just copied those from the cisco section above. The radio0 should be the 2.4GHZ radio and radio 1 is the 5GHZ.

jquagga added some commits Oct 11, 2016
@jquagga jquagga Add wireless client stats for Unifi f060710
@jquagga jquagga Add wireless client stats for Unifi
Amend: Whitespace clean up
@jquagga jquagga Merge branch 'master' of github.com:jquagga/librenms 67a6743
@jquagga jquagga Whitespace cleanup once more b918e8d
@jquagga jquagga More whitespace, pre-commit.php prescribed correction d869db7
@jquagga jquagga I agree to the conditions of the Contributor Agreement contained in

The inspection completed: No new issues

laf commented Oct 11, 2016

That's fine for now.

I also don't see an issue with the snmpgets failing for devices that don't support it. The os check for unifi restricts it just wireless devices and it's only 1 additional snmpget if the first fails.

@laf laf merged commit 534ec84 into librenms:master Oct 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment