Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis bash test #4917

Merged
merged 6 commits into from Nov 3, 2016
Merged

Travis bash test #4917

merged 6 commits into from Nov 3, 2016

Conversation

laf
Copy link
Member

@laf laf commented Nov 1, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

@laf
Copy link
Member Author

laf commented Nov 1, 2016

Leave this for now, travis-ci is having issues displaying logs so I couldn't test it accurately

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4917.ci.librenms.org or https://4917.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@laf laf removed the Blocker 🚫 label Nov 2, 2016
@laf
Copy link
Member Author

laf commented Nov 2, 2016

No longer classed as blocker from my perspective.

@laf
Copy link
Member Author

laf commented Nov 3, 2016

Can be changed if needs be at a later stage but as we have a PR in for daily.sh update again I'd like to at least fail travis if it doesn't syntax check ok.

@laf laf merged commit 6bed6cb into librenms:master Nov 3, 2016
@laf laf deleted the travis-bash-test branch November 3, 2016 07:42
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants