refactor: Watchguard Fireware cleanup #5015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watchguard only has one OS and two main product lines (one defunct) The processor discovery module was discovery average cpu over 5 minutes, while these also support hr proc, so it would show 3 procs when there is 2 for example. Only use sysObjectId to discover, this is much more reliable.
|
Auto-Deploy finished, Test PR at http://5015.ci.librenms.org or https://5015.ci.librenms.org |
|
The inspection completed: No new issues |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note
Watchguard only has one OS and two main product lines (one defunct)
The processor discovery module was discovery average cpu over 5 minutes, while these also support hr proc, so it would show 3 procs when there is 2 for example.
Only use sysObjectId to discover, this is much more reliable.
Use data from actual devices for snmp tests