refactor: Watchguard Fireware cleanup #5015

Merged
merged 1 commit into from Nov 18, 2016

Projects

None yet

4 participants

@murrant
Contributor
murrant commented Nov 18, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Watchguard only has one OS and two main product lines (one defunct)
The processor discovery module was discovery average cpu over 5 minutes, while these also support hr proc, so it would show 3 procs when there is 2 for example.
Only use sysObjectId to discover, this is much more reliable.
Use data from actual devices for snmp tests

@murrant murrant refactor: Watchguard Fireware cleanup
Watchguard only has one OS and two main product lines (one defunct)
The processor discovery module was discovery average cpu over 5 minutes, while these also support hr proc, so it would show 3 procs when there is 2 for example.
Only use sysObjectId to discover, this is much more reliable.
07564d8
@scrutinizer-notifier

The inspection completed: No new issues

@laf laf merged commit c840f99 into librenms:master Nov 18, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant murrant deleted the murrant:fireware branch Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment