New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: collect sysDescr and sysObjectID for stats to improve os detection #5510

Merged
merged 3 commits into from Jan 30, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Jan 19, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jan 19, 2017

Auto-Deploy finished, Test PR at http://5510.ci.librenms.org or https://5510.ci.librenms.org

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jan 19, 2017

Member

@librenms/reviewers Linux systems contain hostname, which I would like to exclude, but for some devices this is valuable data. Others don't contain hostname at all... Examples:

Linux tmurray-linux 4.9.0-gentoo #1 SMP Mon Dec 12 14:44:53 CST 2016 x86_64
Linux RT-AC66U-8300 2.6.22.19 #1 Thu Aug 4 21:21:08 EDT 2016 mips
Linux 2.6.22 #1 PREEMPT Wed Dec 28 22:31:35 PST 2016 mips

Is it worth trying to exclude hostnames? Any good ideas on how to do so effectively without removing valuable data?

Member

murrant commented Jan 19, 2017

@librenms/reviewers Linux systems contain hostname, which I would like to exclude, but for some devices this is valuable data. Others don't contain hostname at all... Examples:

Linux tmurray-linux 4.9.0-gentoo #1 SMP Mon Dec 12 14:44:53 CST 2016 x86_64
Linux RT-AC66U-8300 2.6.22.19 #1 Thu Aug 4 21:21:08 EDT 2016 mips
Linux 2.6.22 #1 PREEMPT Wed Dec 28 22:31:35 PST 2016 mips

Is it worth trying to exclude hostnames? Any good ideas on how to do so effectively without removing valuable data?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jan 19, 2017

Member

Loop through the output from dbFetchRows and do $d = preg_replace('/^Linux ([\w\d\W]+) (\d\.+)/', 'Linux ${2}', $d);?

Linux 4.9.0-gentoo #1 SMP Mon Dec 12 14:44:53 CST 2016 x86_64
Linux 2.6.22.19 #1 Thu Aug 4 21:21:08 EDT 2016 mips
Linux 2.6.22 #1 PREEMPT Wed Dec 28 22:31:35 PST 2016 mips

Also, we need to notify users we are turning this on to give them chance to opt out (docs needs updating). Are we planning to turn it on for just 1 week or leave on all the time?

Member

laf commented Jan 19, 2017

Loop through the output from dbFetchRows and do $d = preg_replace('/^Linux ([\w\d\W]+) (\d\.+)/', 'Linux ${2}', $d);?

Linux 4.9.0-gentoo #1 SMP Mon Dec 12 14:44:53 CST 2016 x86_64
Linux 2.6.22.19 #1 Thu Aug 4 21:21:08 EDT 2016 mips
Linux 2.6.22 #1 PREEMPT Wed Dec 28 22:31:35 PST 2016 mips

Also, we need to notify users we are turning this on to give them chance to opt out (docs needs updating). Are we planning to turn it on for just 1 week or leave on all the time?

filter hostnames from sysDescr
Do not submit entries with both fields null
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jan 20, 2017

Auto-Deploy finished, Test PR at http://5510.ci.librenms.org or https://5510.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jan 20, 2017

Member

Aren't other characters allowed in hostnames other than a-z0-9. ?

Member

laf commented Jan 20, 2017

Aren't other characters allowed in hostnames other than a-z0-9. ?

@murrant

This comment has been minimized.

Show comment
Hide comment
Member

murrant commented Jan 20, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jan 20, 2017

Member

Pending user notification...

Member

murrant commented Jan 20, 2017

Pending user notification...

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jan 22, 2017

Auto-Deploy finished, Test PR at http://5510.ci.librenms.org or https://5510.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jan 22, 2017

The inspection completed: 1 new issues

scrutinizer-notifier commented Jan 22, 2017

The inspection completed: 1 new issues

@murrant murrant removed the Blocker 🚫 label Jan 30, 2017

@laf laf merged commit b06153d into librenms:master Jan 30, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:callback-os branch Jan 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment