feature: collect sysDescr and sysObjectID for stats to improve os detection

[murrant]

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

• Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
• Have you followed our code guidelines?

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://5510.ci.librenms.org or https://5510.ci.librenms.org

[murrant]

@librenms/reviewers Linux systems contain hostname, which I would like to exclude, but for some devices this is valuable data. Others don't contain hostname at all... Examples:

Linux tmurray-linux 4.9.0-gentoo #1 SMP Mon Dec 12 14:44:53 CST 2016 x86_64
Linux RT-AC66U-8300 2.6.22.19 #1 Thu Aug 4 21:21:08 EDT 2016 mips
Linux 2.6.22 #1 PREEMPT Wed Dec 28 22:31:35 PST 2016 mips

Is it worth trying to exclude hostnames? Any good ideas on how to do so effectively without removing valuable data?

[laf]

Loop through the output from dbFetchRows and do $d = preg_replace('/^Linux ([\w\d\W]+) (\d\.+)/', 'Linux ${2}', $d);?

Linux 4.9.0-gentoo #1 SMP Mon Dec 12 14:44:53 CST 2016 x86_64
Linux 2.6.22.19 #1 Thu Aug 4 21:21:08 EDT 2016 mips
Linux 2.6.22 #1 PREEMPT Wed Dec 28 22:31:35 PST 2016 mips

Also, we need to notify users we are turning this on to give them chance to opt out (docs needs updating). Are we planning to turn it on for just 1 week or leave on all the time?

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://5510.ci.librenms.org or https://5510.ci.librenms.org

[laf]

Aren't other characters allowed in hostnames other than a-z0-9. ?

[murrant]

https://tools.ietf.org/html/rfc952 says yes [A-Za-z\.\-]

https://en.m.wikipedia.org/wiki/Hostname

[murrant]

Pending user notification...

[LibreNMS-CI]

Auto-Deploy finished, Test PR at http://5510.ci.librenms.org or https://5510.ci.librenms.org

[scrutinizer-notifier]

The inspection completed: 1 new issues