fix: Add extra check to Junos DOM discovery #5582

Merged
merged 4 commits into from Jan 25, 2017

Projects

None yet

6 participants

@Rosiak
Contributor
Rosiak commented Jan 24, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Should mitigate adding the following:

jnxDomCurrentAlarms.512 = "00 00 00 "
jnxDomCurrentAlarms.513 = "00 00 00 "
jnxDomCurrentAlarms.514 = "00 00 00 "
jnxDomCurrentAlarms.515 = "00 00 00 "
jnxDomCurrentAlarms.516 = "00 00 00 "
jnxDomCurrentAlarms.517 = "00 00 00 "
jnxDomCurrentAlarms.518 = "00 00 00 "
jnxDomCurrentAlarms.519 = "00 00 00 "
jnxDomCurrentAlarms.520 = "00 00 00 "
jnxDomCurrentAlarms.521 = "00 00 00 "
jnxDomCurrentAlarms.522 = "00 00 00 "
jnxDomCurrentAlarms.523 = "00 00 00 "
jnxDomCurrentAlarms.524 = "00 00 00 "
jnxDomCurrentAlarms.525 = "00 00 00 "
jnxDomCurrentAlarms.526 = "00 00 00 "
jnxDomCurrentAlarms.527 = "00 00 00 "
jnxDomCurrentAlarms.528 = "00 00 00 "
jnxDomCurrentAlarms.529 = "00 00 00 "
jnxDomCurrentAlarms.530 = "00 00 00 "
jnxDomCurrentAlarms.531 = "00 00 00 "
jnxDomCurrentAlarmDate.512 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.513 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.514 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.515 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.516 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.517 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.518 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.519 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.520 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.521 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.522 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.523 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.524 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.525 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.526 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.527 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.528 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.529 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.530 = 0-0-0,0:0:0.0,.0:0
jnxDomCurrentAlarmDate.531 = 0-0-0,0:0:0.0,.0:0
jnxDomLastAlarms.512 = "00 00 00 "
jnxDomLastAlarms.513 = "00 00 00 "
jnxDomLastAlarms.514 = "00 00 00 "
jnxDomLastAlarms.515 = "00 00 00 "
jnxDomLastAlarms.516 = "00 00 00 "
jnxDomLastAlarms.517 = "00 00 00 "
jnxDomLastAlarms.518 = "00 00 00 "
jnxDomLastAlarms.519 = "00 00 00 "
jnxDomLastAlarms.520 = "00 00 00 "
jnxDomLastAlarms.521 = "00 00 00 "
jnxDomLastAlarms.522 = "00 00 00 "
jnxDomLastAlarms.523 = "00 00 00 "
jnxDomLastAlarms.524 = "00 00 00 "
jnxDomLastAlarms.525 = "00 00 00 "
jnxDomLastAlarms.526 = "00 00 00 "
jnxDomLastAlarms.527 = "00 00 00 "
jnxDomLastAlarms.528 = "00 00 00 "
jnxDomLastAlarms.529 = "00 00 00 "
jnxDomLastAlarms.530 = "00 00 00 "
jnxDomLastAlarms.531 = "00 00 00 "
jnxDomCurrentWarnings.512 = "00 00 00 "
jnxDomCurrentWarnings.513 = "00 00 00 "
jnxDomCurrentWarnings.514 = "00 00 00 "
jnxDomCurrentWarnings.515 = "00 00 00 "
jnxDomCurrentWarnings.516 = "00 00 00 "
jnxDomCurrentWarnings.517 = "00 00 00 "
jnxDomCurrentWarnings.518 = "00 00 00 "
jnxDomCurrentWarnings.519 = "00 00 00 "
jnxDomCurrentWarnings.520 = "00 00 00 "
jnxDomCurrentWarnings.521 = "00 00 00 "
jnxDomCurrentWarnings.522 = "00 00 00 "
jnxDomCurrentWarnings.523 = "00 00 00 "
jnxDomCurrentWarnings.524 = "00 00 00 "
jnxDomCurrentWarnings.525 = "00 00 00 "
jnxDomCurrentWarnings.526 = "00 00 00 "
jnxDomCurrentWarnings.527 = "00 00 00 "
jnxDomCurrentWarnings.528 = "00 00 00 "
jnxDomCurrentWarnings.529 = "00 00 00 "
jnxDomCurrentWarnings.530 = "00 00 00 "
jnxDomCurrentWarnings.531 = "00 00 00 "
jnxDomCurrentRxLaserPower.512 = 0
jnxDomCurrentRxLaserPower.513 = 0
jnxDomCurrentRxLaserPower.514 = 0
jnxDomCurrentRxLaserPower.515 = 0
jnxDomCurrentRxLaserPower.516 = 0
jnxDomCurrentRxLaserPower.517 = 0
jnxDomCurrentRxLaserPower.518 = 0
jnxDomCurrentRxLaserPower.519 = 0
jnxDomCurrentRxLaserPower.520 = 0
jnxDomCurrentRxLaserPower.521 = 0
jnxDomCurrentRxLaserPower.522 = 0
jnxDomCurrentRxLaserPower.523 = 0
jnxDomCurrentRxLaserPower.524 = 0
jnxDomCurrentRxLaserPower.525 = 0
jnxDomCurrentRxLaserPower.526 = 0
jnxDomCurrentRxLaserPower.527 = 0
jnxDomCurrentRxLaserPower.528 = 0
jnxDomCurrentRxLaserPower.529 = 0
jnxDomCurrentRxLaserPower.530 = 0
jnxDomCurrentRxLaserPower.531 = 0
jnxDomCurrentTxLaserBiasCurrent.512 = 0
jnxDomCurrentTxLaserBiasCurrent.513 = 0
jnxDomCurrentTxLaserBiasCurrent.514 = 0
jnxDomCurrentTxLaserBiasCurrent.515 = 0
jnxDomCurrentTxLaserBiasCurrent.516 = 0
jnxDomCurrentTxLaserBiasCurrent.517 = 0
jnxDomCurrentTxLaserBiasCurrent.518 = 0
jnxDomCurrentTxLaserBiasCurrent.519 = 0
jnxDomCurrentTxLaserBiasCurrent.520 = 0
jnxDomCurrentTxLaserBiasCurrent.521 = 0
jnxDomCurrentTxLaserBiasCurrent.522 = 0
jnxDomCurrentTxLaserBiasCurrent.523 = 0
jnxDomCurrentTxLaserBiasCurrent.524 = 0
jnxDomCurrentTxLaserBiasCurrent.525 = 0
jnxDomCurrentTxLaserBiasCurrent.526 = 0
jnxDomCurrentTxLaserBiasCurrent.527 = 0
jnxDomCurrentTxLaserBiasCurrent.528 = 0
jnxDomCurrentTxLaserBiasCurrent.529 = 0
jnxDomCurrentTxLaserBiasCurrent.530 = 0
jnxDomCurrentTxLaserBiasCurrent.531 = 0
jnxDomCurrentTxLaserOutputPower.512 = 0
jnxDomCurrentTxLaserOutputPower.513 = 0
jnxDomCurrentTxLaserOutputPower.514 = 0
jnxDomCurrentTxLaserOutputPower.515 = 0
jnxDomCurrentTxLaserOutputPower.516 = 0
jnxDomCurrentTxLaserOutputPower.517 = 0
jnxDomCurrentTxLaserOutputPower.518 = 0
jnxDomCurrentTxLaserOutputPower.519 = 0
jnxDomCurrentTxLaserOutputPower.520 = 0
jnxDomCurrentTxLaserOutputPower.521 = 0
jnxDomCurrentTxLaserOutputPower.522 = 0
jnxDomCurrentTxLaserOutputPower.523 = 0
jnxDomCurrentTxLaserOutputPower.524 = 0
jnxDomCurrentTxLaserOutputPower.525 = 0
jnxDomCurrentTxLaserOutputPower.526 = 0
jnxDomCurrentTxLaserOutputPower.527 = 0
jnxDomCurrentTxLaserOutputPower.528 = 0
jnxDomCurrentTxLaserOutputPower.529 = 0
jnxDomCurrentTxLaserOutputPower.530 = 0
jnxDomCurrentTxLaserOutputPower.531 = 0
jnxDomCurrentModuleTemperature.512 = 0
jnxDomCurrentModuleTemperature.513 = 0
jnxDomCurrentModuleTemperature.514 = 0
jnxDomCurrentModuleTemperature.515 = 0
jnxDomCurrentModuleTemperature.516 = 0
jnxDomCurrentModuleTemperature.517 = 0
jnxDomCurrentModuleTemperature.518 = 0
jnxDomCurrentModuleTemperature.519 = 0
jnxDomCurrentModuleTemperature.520 = 0
jnxDomCurrentModuleTemperature.521 = 0
jnxDomCurrentModuleTemperature.522 = 0
jnxDomCurrentModuleTemperature.523 = 0
jnxDomCurrentModuleTemperature.524 = 0
jnxDomCurrentModuleTemperature.525 = 0
jnxDomCurrentModuleTemperature.526 = 0
jnxDomCurrentModuleTemperature.527 = 0
jnxDomCurrentModuleTemperature.528 = 0
jnxDomCurrentModuleTemperature.529 = 0
jnxDomCurrentModuleTemperature.530 = 0
jnxDomCurrentModuleTemperature.531 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.512 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.513 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.514 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.515 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.516 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.517 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.518 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.519 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.520 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.521 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.522 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.523 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.524 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.525 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.526 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.527 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.528 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.529 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.530 = 0
jnxDomCurrentRxLaserPowerHighAlarmThreshold.531 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.512 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.513 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.514 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.515 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.516 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.517 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.518 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.519 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.520 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.521 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.522 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.523 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.524 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.525 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.526 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.527 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.528 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.529 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.530 = 0
jnxDomCurrentRxLaserPowerLowAlarmThreshold.531 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.512 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.513 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.514 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.515 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.516 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.517 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.518 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.519 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.520 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.521 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.522 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.523 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.524 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.525 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.526 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.527 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.528 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.529 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.530 = 0
jnxDomCurrentRxLaserPowerHighWarningThreshold.531 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.512 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.513 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.514 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.515 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.516 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.517 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.518 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.519 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.520 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.521 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.522 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.523 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.524 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.525 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.526 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.527 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.528 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.529 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.530 = 0
jnxDomCurrentRxLaserPowerLowWarningThreshold.531 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.512 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.513 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.514 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.515 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.516 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.517 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.518 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.519 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.520 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.521 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.522 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.523 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.524 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.525 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.526 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.527 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.528 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.529 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.530 = 0
jnxDomCurrentTxLaserBiasCurrentHighAlarmThreshold.531 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.512 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.513 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.514 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.515 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.516 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.517 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.518 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.519 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.520 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.521 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.522 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.523 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.524 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.525 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.526 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.527 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.528 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.529 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.530 = 0
jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold.531 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.512 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.513 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.514 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.515 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.516 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.517 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.518 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.519 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.520 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.521 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.522 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.523 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.524 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.525 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.526 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.527 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.528 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.529 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.530 = 0
jnxDomCurrentTxLaserBiasCurrentHighWarningThreshold.531 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.512 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.513 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.514 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.515 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.516 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.517 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.518 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.519 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.520 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.521 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.522 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.523 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.524 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.525 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.526 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.527 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.528 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.529 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.530 = 0
jnxDomCurrentTxLaserBiasCurrentLowWarningThreshold.531 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.512 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.513 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.514 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.515 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.516 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.517 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.518 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.519 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.520 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.521 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.522 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.523 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.524 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.525 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.526 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.527 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.528 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.529 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.530 = 0
jnxDomCurrentTxLaserOutputPowerHighAlarmThreshold.531 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.512 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.513 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.514 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.515 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.516 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.517 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.518 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.519 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.520 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.521 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.522 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.523 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.524 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.525 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.526 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.527 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.528 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.529 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.530 = 0
jnxDomCurrentTxLaserOutputPowerLowAlarmThreshold.531 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.512 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.513 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.514 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.515 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.516 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.517 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.518 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.519 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.520 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.521 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.522 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.523 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.524 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.525 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.526 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.527 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.528 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.529 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.530 = 0
jnxDomCurrentTxLaserOutputPowerHighWarningThreshold.531 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.512 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.513 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.514 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.515 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.516 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.517 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.518 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.519 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.520 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.521 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.522 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.523 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.524 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.525 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.526 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.527 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.528 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.529 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.530 = 0
jnxDomCurrentTxLaserOutputPowerLowWarningThreshold.531 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.512 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.513 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.514 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.515 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.516 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.517 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.518 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.519 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.520 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.521 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.522 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.523 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.524 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.525 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.526 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.527 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.528 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.529 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.530 = 0
jnxDomCurrentModuleTemperatureHighAlarmThreshold.531 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.512 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.513 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.514 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.515 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.516 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.517 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.518 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.519 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.520 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.521 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.522 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.523 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.524 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.525 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.526 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.527 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.528 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.529 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.530 = 0
jnxDomCurrentModuleTemperatureLowAlarmThreshold.531 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.512 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.513 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.514 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.515 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.516 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.517 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.518 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.519 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.520 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.521 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.522 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.523 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.524 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.525 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.526 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.527 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.528 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.529 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.530 = 0
jnxDomCurrentModuleTemperatureHighWarningThreshold.531 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.512 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.513 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.514 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.515 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.516 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.517 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.518 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.519 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.520 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.521 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.522 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.523 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.524 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.525 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.526 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.527 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.528 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.529 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.530 = 0
jnxDomCurrentModuleTemperatureLowWarningThreshold.531 = 0
jnxDomCurrentModuleVoltage.512 = 0
jnxDomCurrentModuleVoltage.513 = 0
jnxDomCurrentModuleVoltage.514 = 0
jnxDomCurrentModuleVoltage.515 = 0
jnxDomCurrentModuleVoltage.516 = 0
jnxDomCurrentModuleVoltage.517 = 0
jnxDomCurrentModuleVoltage.518 = 0
jnxDomCurrentModuleVoltage.519 = 0
jnxDomCurrentModuleVoltage.520 = 0
jnxDomCurrentModuleVoltage.521 = 0
jnxDomCurrentModuleVoltage.522 = 0
jnxDomCurrentModuleVoltage.523 = 0
jnxDomCurrentModuleVoltage.524 = 0
jnxDomCurrentModuleVoltage.525 = 0
jnxDomCurrentModuleVoltage.526 = 0
jnxDomCurrentModuleVoltage.527 = 0
jnxDomCurrentModuleVoltage.528 = 0
jnxDomCurrentModuleVoltage.529 = 0
jnxDomCurrentModuleVoltage.530 = 0
jnxDomCurrentModuleVoltage.531 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.512 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.513 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.514 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.515 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.516 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.517 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.518 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.519 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.520 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.521 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.522 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.523 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.524 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.525 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.526 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.527 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.528 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.529 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.530 = 0
jnxDomCurrentModuleVoltageHighAlarmThreshold.531 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.512 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.513 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.514 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.515 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.516 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.517 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.518 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.519 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.520 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.521 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.522 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.523 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.524 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.525 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.526 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.527 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.528 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.529 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.530 = 0
jnxDomCurrentModuleVoltageLowAlarmThreshold.531 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.512 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.513 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.514 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.515 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.516 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.517 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.518 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.519 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.520 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.521 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.522 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.523 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.524 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.525 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.526 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.527 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.528 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.529 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.530 = 0
jnxDomCurrentModuleVoltageHighWarningThreshold.531 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.512 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.513 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.514 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.515 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.516 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.517 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.518 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.519 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.520 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.521 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.522 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.523 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.524 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.525 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.526 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.527 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.528 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.529 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.530 = 0
jnxDomCurrentModuleVoltageLowWarningThreshold.531 = 0
jnxDomCurrentModuleLaneCount.512 = 1
jnxDomCurrentModuleLaneCount.513 = 1
jnxDomCurrentModuleLaneCount.514 = 1
jnxDomCurrentModuleLaneCount.515 = 1
jnxDomCurrentModuleLaneCount.516 = 1
jnxDomCurrentModuleLaneCount.517 = 1
jnxDomCurrentModuleLaneCount.518 = 1
jnxDomCurrentModuleLaneCount.519 = 1
jnxDomCurrentModuleLaneCount.520 = 1
jnxDomCurrentModuleLaneCount.521 = 1
jnxDomCurrentModuleLaneCount.522 = 1
jnxDomCurrentModuleLaneCount.523 = 1
jnxDomCurrentModuleLaneCount.524 = 1
jnxDomCurrentModuleLaneCount.525 = 1
jnxDomCurrentModuleLaneCount.526 = 1
jnxDomCurrentModuleLaneCount.527 = 1
jnxDomCurrentModuleLaneCount.528 = 1
jnxDomCurrentModuleLaneCount.529 = 1
jnxDomCurrentModuleLaneCount.530 = 1
jnxDomCurrentModuleLaneCount.531 = 1
Rosiak added some commits Jan 24, 2017
@Rosiak Rosiak fix: Add extra check to Junos DOM discovery f233152
@Rosiak Rosiak add extra check
eb8e75c
@mention-bot

Thank you for submitting a PR @Rosiak! We have found the following @laf and @murrant based on the history of these files to review this PR.

@Rosiak Rosiak changed the title from Fix juniper sensor disco to fix: Add extra check to Junos DOM discovery Jan 24, 2017
@@ -16,7 +16,7 @@
$multiplier = 1;
$divisor = 1000000;
foreach ($junos_oids as $index => $entry) {
- if (is_numeric($entry['jnxDomCurrentTxLaserBiasCurrent'])) {
+ if (is_numeric($entry['jnxDomCurrentTxLaserBiasCurrent']) && $entry['jnxDomCurrentTxLaserBiasCurrent'] && $entry['jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold'] != 0) {
@laf
laf Jan 24, 2017 Member

Is it not worth setting jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold to null so we can still discovery the sensor here?

@Rosiak
Rosiak Jan 24, 2017 Contributor

Was a bit fast, just added another != 0.

@laf
laf Jan 24, 2017 Member

That's not what I meant, here we are skipping the sensor_discovery because the low threshold is 0, we should ignore that and set it to null if it's 0 so thresholds are auto discovered

@Rosiak
Rosiak Jan 25, 2017 Contributor

No we are skipping the sensor discovery if $entry['jnxDomCurrentTxLaserBiasCurrent'] != 0 AND $entry['jnxDomCurrentTxLaserBiasCurrentLowAlarmThreshold'] != 0.

The idea by doing this is to catch invalid entry's like the ones pasted in the PR.

Forgive me if I'm not getting your point.

@laf
laf Jan 25, 2017 Member

Yes but why not only skip jnxDomCurrentTxLaserBiasCurrent? We can calculate the threshold so just null it if it's invalid and allow the sensor to be discovered.

@Rosiak Rosiak too fast.
373cddc
@murrant murrant Fix typ
5405a06
@laf laf merged commit 7bae2cf into librenms:master Jan 25, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@scrutinizer-notifier

The inspection completed: No new issues

@Rosiak Rosiak deleted the Rosiak:fix-juniper-sensor-disco branch Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment