Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: New LibreNMS logo assets #5629

Merged
merged 1 commit into from Jan 27, 2017

Conversation

Projects
None yet
6 participants
@murrant
Copy link
Member

murrant commented Jan 27, 2017

SVG images where we can.
Updated favicon and app icons.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
webui: New LibreNMS logo assets
SVG images where we can.
Updated favicon and app icons.
@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Jan 27, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @Rosiak and @arjitc based on the history of these files to review this PR.

@murrant

This comment has been minimized.

Copy link
Member Author

murrant commented Jan 27, 2017

An example, not much different, but should look much better on HiDPI.

Old:
librenms-header-mono-old
librenms-old

New:
librenms-header-mono
librenms-new

@LibreNMS-CI

This comment has been minimized.

Copy link

LibreNMS-CI commented Jan 27, 2017

Auto-Deploy finished, Test PR at http://5629.ci.librenms.org or https://5629.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Jan 27, 2017

The inspection completed: No new issues

@InsaneSplash

This comment has been minimized.

Copy link
Contributor

InsaneSplash commented Jan 27, 2017

Nice!

@laf

This comment has been minimized.

Copy link
Member

laf commented Jan 27, 2017

The only thing with this is the export to pdf (used once in alerts log), it doesn't render properly. Really not an issue but we should address.

@laf laf merged commit afe887d into librenms:master Jan 27, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf

This comment has been minimized.

Copy link
Member

laf commented Jan 27, 2017

btw looks freakin sweet :)

@murrant murrant deleted the murrant:librenms-logo branch Jan 27, 2017

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.