device: Improved hardware detection for Xerox (case issue) #5831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-Deploy finished, Test PR at http://5831.ci.librenms.org or https://5831.ci.librenms.org |
rockyluke
changed the title
rockyluke
changed the title
laf
reviewed
Feb 8, 2017
includes/polling/os/xerox.inc.php
Outdated
| @@ -2,14 +2,21 @@ | |||
|
|
|||
| // ...253.8.51.1.2.1.20.1 = STRING: "MFG:Xerox;CMD:Adobe PostScript 3,PCL;MDL:Phaser 4510N;CLS:Printer;DES:Xerox Phaser 4510 Laser Printer, PostScript 3, Letter/A4 Size" | |||
| // ...253.8.51.1.2.1.20.1 = STRING: "MFG:Xerox;CMD:Adobe PostScript 3,PCL;MDL:ColorQube 8880DN;CLS:Printer;DES:Xerox ColorQube 8580 & 8880, Color Printer,PostScript 3,Letter/A4 Size " | |||
| // ...253.8.51.1.2.1.20.1 = STRING: "MFG:Xerox; CMD:PCL, PJL, POSTSCRIPT; MDL:WorkCentre 7535; CLS:Printer; Des:Xerox WorkCentre 7535" | |||
| $xinfo = explode(';', trim(snmp_get($device, '1.3.6.1.4.1.253.8.51.1.2.1.20.1', '-OQv', '', ''), '" ')); | |||
|
|
|||
| foreach ($xinfo as $xi) { | |||
| list($key,$value) = explode(':', trim($xi)); | |||
There was a problem hiding this comment.
Would it not be easier to just run http://uk1.php.net/manual/en/function.strtoupper.php on $key before it's used in $xerox then you don't need to worry about case?
There was a problem hiding this comment.
Yes, easier and cleaner !
|
Auto-Deploy finished, Test PR at http://5831.ci.librenms.org or https://5831.ci.librenms.org |
|
The inspection completed: No new issues |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT DELETE THIS TEXT
Please note
Simply DES vs. Des.