New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add FreeBSD NFS Client/Server application support #6008

Merged
merged 77 commits into from Mar 3, 2017

Conversation

Projects
None yet
6 participants
@VVelox
Contributor

VVelox commented Feb 26, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This depends on librenms/librenms-agent#90 .

VVelox and others added some commits Feb 15, 2017

kitsune
*rename it so it can be called via the apps page
*setup the apps page to call it
@VVelox

This comment has been minimized.

Contributor

VVelox commented Feb 27, 2017

Removed unneeded require lines.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Feb 27, 2017

Auto-Deploy finished, Test PR at http://6008.ci.librenms.org or https://6008.ci.librenms.org

$oid = 'nsExtendOutLine.13.102.98.115.100.110.102.115.99.108.105.101.110.116';
$nfsclient = snmp_walk($device, $oid, $options, $mib);
list( $Getattr, $Setattr, $Lookup, $Readlink, $Read, $Write, $Create, $Remove, $Rename, $Link, $Symlink, $Mkdir, $Rmdir,

This comment has been minimized.

@laf

laf Mar 1, 2017

Member

Can you remove the space after list(

$oid = 'nsExtendOutLine.13.102.98.115.100.110.102.115.115.101.114.118.101.114';
$nfsserver = snmp_walk($device, $oid, $options, $mib);
list( $Getattr, $Setattr, $Lookup, $Readlink, $Read, $Write, $Create, $Remove, $Rename, $Link, $Symlink,

This comment has been minimized.

@laf

laf Mar 1, 2017

Member

Space on list( again.

This comment has been minimized.

@laf

laf Mar 1, 2017

Member

One at the end.

@laf

Just a couple of small changes + a rebase

@laf laf changed the title from add FreeBSD NFS Client/Server app to feature: Add FreeBSD NFS Client/Server application support Mar 1, 2017

@VVelox

This comment has been minimized.

Contributor

VVelox commented Mar 1, 2017

Sweet. All changes made now.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 2, 2017

Auto-Deploy finished, Test PR at http://6008.ci.librenms.org or https://6008.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 2, 2017

Auto-Deploy finished, Test PR at http://6008.ci.librenms.org or https://6008.ci.librenms.org

VVelox added some commits Mar 2, 2017

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 2, 2017

Auto-Deploy finished, Test PR at http://6008.ci.librenms.org or https://6008.ci.librenms.org

1 similar comment
@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 2, 2017

Auto-Deploy finished, Test PR at http://6008.ci.librenms.org or https://6008.ci.librenms.org

@laf

This comment has been minimized.

Member

laf commented Mar 2, 2017

Can you change all variables to lowercase please.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 3, 2017

Auto-Deploy finished, Test PR at http://6008.ci.librenms.org or https://6008.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 3, 2017

The inspection completed: 2 new issues

@laf

laf approved these changes Mar 3, 2017

@laf laf merged commit 354bd21 into librenms:master Mar 3, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@VVelox VVelox deleted the VVelox:FreeBSD-NFS branch Mar 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment