Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add FreeBSD NFS Client/Server application support #6008

Merged
merged 77 commits into from Mar 3, 2017
Merged

feature: Add FreeBSD NFS Client/Server application support #6008

merged 77 commits into from Mar 3, 2017

Conversation

VVelox
Copy link
Contributor

@VVelox VVelox commented Feb 26, 2017 •
edited

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This depends on librenms/librenms-agent#90 .

VVelox and others added 30 commits February 15, 2017 11:19
@VVelox
add single pool based poller for php-fpm
327c3ae
@VVelox
add the page for php-fpm
ee580bc
@VVelox
add graph for php-fpm
c6a1bf3
@VVelox
I agree to the conditions of the Contributor Agreement contained in d…
0f875ef 
…oc/General/Contributing.md.
@VVelox
use named OID as suggest by @laf
470ee9e
@VVelox
document PHP-FPM monitoring
c6a9750
@VVelox
link it in the index
3a10929
@VVelox
clean up the named oid
3bb1c25
@VVelox
add how to grab the script in question
2832322
Merge branch 'master' of https://github.com/librenms/librenms
15941b7
@VVelox
add f2b poller
7cc52df
@VVelox
add f2b app page
6aeb2e0
@VVelox
add f2b graph
12d18bc
@VVelox
add fail2ban notes
5d3d6ff
@VVelox
minor formatting cleanup
b915e91
@VVelox
...more formatting cleanup
927395e
rename it so it can be called via the app page
0bde88a
Revert "rename it so it can be called via the app page"
0ca7f03 
This reverts commit 0bde88a.
*rename it so it can be called via the apps page
52dde90 
*setup the apps page to call it
@VVelox
renamed the graph
4e4905d
now include fail2ban in the apps properly
d2bc507
Merge branch 'master' of https://github.com/VVelox/librenms
d9cdd23
@VVelox
correct the wget command so it does not stomp on phpfpm-sp
0298985
@VVelox
update the fail2ban poller for the newest fail2ban script and now bui…
aee607b 
…ld multiple RRDs
@VVelox
update for now graphing firewalled and banned
cf93266
@VVelox
update fail2ban docs to match the newest snmpd extend method
7936203
@VVelox
search automatically for jails and graph them
63d72e3
@VVelox
graphs the currently banned for a fail2ban jail
340b32d
@VVelox
change the tital of the graph for the total banned to make it more de…
87826eb 
…scriptive
@VVelox
Add a explanation of the two variables in the total graph.
0feda68
@VVelox
Copy link
Contributor Author

VVelox commented Feb 27, 2017 •
edited

Removed unneeded require lines.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6008.ci.librenms.org or https://6008.ci.librenms.org

laf
laf reviewed Mar 1, 2017
View reviewed changes
includes/polling/applications/fbsd-nfs-client.inc.php Outdated
$oid = 'nsExtendOutLine.13.102.98.115.100.110.102.115.99.108.105.101.110.116';
$nfsclient = snmp_walk($device, $oid, $options, $mib);

list( $Getattr, $Setattr, $Lookup, $Readlink, $Read, $Write, $Create, $Remove, $Rename, $Link, $Symlink, $Mkdir, $Rmdir,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the space after list(

laf
laf reviewed Mar 1, 2017
View reviewed changes
includes/polling/applications/fbsd-nfs-server.inc.php Outdated
$oid = 'nsExtendOutLine.13.102.98.115.100.110.102.115.115.101.114.118.101.114';
$nfsserver = snmp_walk($device, $oid, $options, $mib);

list( $Getattr, $Setattr, $Lookup, $Readlink, $Read, $Write, $Create, $Remove, $Rename, $Link, $Symlink,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space on list( again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One at the end.

laf
laf requested changes Mar 1, 2017
View reviewed changes
Copy link
Member

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small changes + a rebase

@laf laf changed the title add FreeBSD NFS Client/Server app feature: Add FreeBSD NFS Client/Server application support Mar 1, 2017
@VVelox
Copy link
Contributor Author

VVelox commented Mar 1, 2017

Sweet. All changes made now.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6008.ci.librenms.org or https://6008.ci.librenms.org

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6008.ci.librenms.org or https://6008.ci.librenms.org

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6008.ci.librenms.org or https://6008.ci.librenms.org

1 similar comment
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6008.ci.librenms.org or https://6008.ci.librenms.org

@laf
Copy link
Member

laf commented Mar 2, 2017

Can you change all variables to lowercase please.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6008.ci.librenms.org or https://6008.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: 2 new issues

@laf laf merged commit 354bd21 into librenms:master Mar 3, 2017
@VVelox VVelox deleted the FreeBSD-NFS branch March 4, 2017 15:36
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laf laf laf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@VVelox @mention-bot @LibreNMS-CI @laf @scrutinizer-notifier @murrant