fix: yaml files for edgeos and edgeswitch #6208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-Deploy finished, Test PR at http://6208.ci.librenms.org or https://6208.ci.librenms.org |
|
Auto-Deploy finished, Test PR at http://6208.ci.librenms.org or https://6208.ci.librenms.org |
|
The inspection completed: No new issues |
|
What are you trying to fix here? Both of these have generic sysObjectIDs so using sysObjectID alone is problematic. |
|
on edgeswitch is just alignment issue.
on edgeos i've added sysObjectID.
… On Mar 16, 2017, at 16:06, Tony Murray ***@***.***> wrote:
What are you trying to fix here?
Both these devices share the same sysObjectID which is why they are problematic.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Do we need a new test to validate these changes? |
|
no, the sysobjectid is already added in the edgeos.snmprec |
|
Looks good. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926discovery based only on sysdescr is not relevant in case of edgeos because that value can be changed via cli: set service snmp description command so i've added the sysObjectID match (which is already added in the tests files).
edgeswitch yaml file was malformed