fix: yaml files for edgeos and edgeswitch #6208

Merged
merged 2 commits into from Mar 16, 2017

Conversation

Projects
None yet
5 participants
@crcro
Contributor

crcro commented Mar 16, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

  1. discovery based only on sysdescr is not relevant in case of edgeos because that value can be changed via cli: set service snmp description command so i've added the sysObjectID match (which is already added in the tests files).

  2. edgeswitch yaml file was malformed

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 16, 2017

Thank you for submitting a PR @crcro! We have found the following @laf and @murrant based on the history of these files to review this PR.

Thank you for submitting a PR @crcro! We have found the following @laf and @murrant based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 16, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 16, 2017

Member

What are you trying to fix here?

Both of these have generic sysObjectIDs so using sysObjectID alone is problematic.

Member

murrant commented Mar 16, 2017

What are you trying to fix here?

Both of these have generic sysObjectIDs so using sysObjectID alone is problematic.

@crcro

This comment has been minimized.

Show comment
Hide comment
@crcro

crcro Mar 16, 2017

Contributor
Contributor

crcro commented Mar 16, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 16, 2017

Member

Do we need a new test to validate these changes?

Member

murrant commented Mar 16, 2017

Do we need a new test to validate these changes?

@crcro

This comment has been minimized.

Show comment
Hide comment
@crcro

crcro Mar 16, 2017

Contributor

no, the sysobjectid is already added in the edgeos.snmprec

Contributor

crcro commented Mar 16, 2017

no, the sysobjectid is already added in the edgeos.snmprec

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 16, 2017

Member

Looks good. Thanks!

Member

murrant commented Mar 16, 2017

Looks good. Thanks!

@murrant murrant merged commit 7fb4081 into librenms:master Mar 16, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@crcro crcro deleted the crcro:fix-edgeos-edgeswitch branch Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment